Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DynamodB] Fix Flaky Pagination UT #174

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Jan 12, 2024

Why are these changes needed?

Noticed when adding items to dB following values for requestedAt resulting in key28 being returned as the first key on a query.

// requestedAt: 1705040877
// metadataKey: key28
// BlobKey: blob28
// requestedAt: 1705040877
// metadataKey: key29
// BlobKey: blob29

Fixed it by increasing time duration for requestedAt between adding each item

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore merged commit 9384746 into Layr-Labs:master Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants