Auto correct the IP if the operator set their IP to localhost when opt-in #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmb-software-consulting
changed the title
jianoaix
reviewed
Dec 19, 2023
|
@shrimalmadhur This can affect the operator setup or experience. |
added 2 commits
December 19, 2023 12:10
jianoaix
reviewed
Dec 19, 2023
jianoaix
reviewed
Dec 20, 2023
jianoaix
reviewed
Dec 20, 2023
| PubIPProviderFlag = cli.StringFlag{ | ||
| Name: "public-ip-provider", | ||
| Usage: "The ip provider service used to obtain a operator's public IP [seeip (default), ipify)", | ||
| Required: true, |
There was a problem hiding this comment.
Does this need to be required? @shrimalmadhur
There was a problem hiding this comment.
oh umm - I don't think we should put it as required - can we make this as optional and by default point to seeip?
We can re-use the .env one in the setup
jianoaix
reviewed
Dec 20, 2023
jianoaix
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We are seeing more operators setting their Node IP to localhost.
Such Nodes won't be reachable from public. We should auto correct the IP (from localhost to current IP with IP checker) when the operator registers.
Checks