Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blob ratelimit #121

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Add blob ratelimit #121

merged 7 commits into from
Dec 20, 2023

Conversation

mooselumph
Copy link
Collaborator

@mooselumph mooselumph commented Dec 13, 2023 •
edited
Loading

Why are these changes needed?

Adds system-level and account-level blobs/sec ratelimit to disperser.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

jianoaix
jianoaix reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, just a couple minor comments

disperser/apiserver/rate_config.go Show resolved Hide resolved
disperser/apiserver/rate_config.go Outdated Show resolved Hide resolved
@mooselumph mooselumph marked this pull request as ready for review December 20, 2023 05:25
jianoaix
jianoaix approved these changes Dec 20, 2023
View reviewed changes
disperser/apiserver/server.go Outdated Show resolved Hide resolved
disperser/apiserver/rate_config.go Show resolved Hide resolved
@mooselumph mooselumph merged commit 837398e into Layr-Labs:master Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@siddimore siddimore Awaiting requested review from siddimore

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mooselumph @jianoaix