feat(failover): return 503 to batcher when eigenda is down #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
commented
Oct 25, 2024
bxue-l2
reviewed
Oct 25, 2024
samlaf
force-pushed
the
samlaf/feat--503-error-logic-with-retries
branch
from
4b77864
to
873ab93
Compare
bxue-l2
reviewed
Oct 29, 2024
bxue-l2
previously approved these changes
Oct 30, 2024
samlaf
force-pushed
the
samlaf/feat--503-error-logic-with-retries
branch
from
f317339
to
727a63d
Compare
chore: go mod tidy to generate go.mod feat: dealing with new eigenda-client grpc errors + ErrorFailover convention comment: fix typo feat(handlers): postShared returns 429 when disperser rate limited client flag(eigenda): rename RetriesBeforeFailover -> PutRetries reviewer correctly pointed out that retrying was more general than only for failovers lint: nolint exhaustive switch check for Put case
samlaf
force-pushed
the
samlaf/feat--503-error-logic-with-retries
branch
from
9c6a735
to
574a762
Compare
bxue-l2
reviewed
Nov 3, 2024
| @@ -5,7 +5,8 @@ go 1.22 | |||
| toolchain go1.22.0 | |||
|
|
|||
| require ( | |||
| github.com/Layr-Labs/eigenda v0.8.5-0.20241031144746-e2ead56a306d | |||
| github.com/Layr-Labs/eigenda v0.8.5-rc.0.0.20241101212705-fa8776ae648c | |||
There was a problem hiding this comment.
after core mainnet release, remember to change it into v0.8.5
There was a problem hiding this comment.
yep, added a TODO note in https://linear.app/eigenlabs/issue/EBE-106/proxy-v160-release
bxue-l2
reviewed
Nov 3, 2024
epociask
reviewed
Nov 5, 2024
server/handlers.go
Outdated
| } else { | ||
| case is429(err): | ||
| http.Error(w, err.Error(), http.StatusTooManyRequests) | ||
| case errors.Is(err, &api.ErrorFailover{}): |
There was a problem hiding this comment.
shouldn't this be namedis503(err)?
bxue-l2
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Layr-Labs/eigenda#828
Would appreciate a quick review for the logic, but leaving as draft because I think I will refactor the api errors that we return from eigenda-client (don't like api.ErrorAPI name and also using http status codes in them).
TODO:
Fixes Issue
Fixes #
Changes proposed
Screenshots (Optional)
Note to reviewers