BREAKING suggestion: change dockerfile to use entrypoint instead of cmd #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally prefer my dockerfiles that are meant to run a single binary to have that binary as the entrypoint. This way I just have to pass the flags directly and don't need to know how the binary was named inside the image.
Compare with this change
to what we currently have
This is wordy for no reason, but also I need to inspect Dockerfile manually to check where the binary is located.
This is a breaking change however, given that RaaS's or whoever has this setup in a docker-compose file somewhere will need to change their CMD to work with this (just remove the name of the binary)