Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travel CI test failed (tornadox-5.x require python-3.4+) #254

Open
dictoss opened this issue Dec 15, 2018 · 2 comments
Open

Travel CI test failed (tornadox-5.x require python-3.4+) #254

dictoss opened this issue Dec 15, 2018 · 2 comments

Comments

@dictoss
Copy link

dictoss commented Dec 15, 2018

Travel CI test failed.
https://travis-ci.org/Lawouach/WebSocket-for-Python/builds/409454320?utm_source=github_status&utm_medium=notification

This test passed python2.7 and python3.5, failed python3.3.

The Travel CI test use tornado-5.1.1, but not supported python-3.3. (tornado-5 require python3.4+)

In my opinion, install to exclude tronado-5.x in py3kreqs.txt .

-tornado>=4.2.3
+tornado>=4.2.3,<5.0.0

@dictoss
Copy link
Author

dictoss commented Dec 15, 2018

Add tornado version info.

https://pypi.org/project/tornado/5.1.1/
Programming Language
Python :: 2
Python :: 2.7
Python :: 3
Python :: 3.4
Python :: 3.5
Python :: 3.6
Python :: 3.7
Python :: Implementation :: CPython
Python :: Implementation :: PyPy

https://pypi.org/project/tornado/4.5.3/
Programming Language
Python :: 2
Python :: 2.7
Python :: 3
Python :: 3.3 <---- notice !!
Python :: 3.4
Python :: 3.5
Python :: 3.6
Python :: Implementation :: CPython
Python :: Implementation :: PyPy

dictoss added a commit to dictoss/WebSocket-for-Python that referenced this issue Dec 15, 2018
@auvipy
Copy link
Collaborator

auvipy commented May 21, 2023

this will be fixed very soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants