Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no implementation to get the (Parameter-)ENUMERATION as string only. #108

Open
astedler opened this issue Jun 3, 2020 · 2 comments

Comments

@astedler
Copy link
Contributor

astedler commented Jun 3, 2020

I missed the possiboility to get the Enumeration just as a astring (like it is transmitted)

But this could be done easily:
in
libember\Headers\ember\glow\GlowParameterBase.hpp
insert soemwhere around line 347:

            /**
             * returns the enumration string
             * @return Returns the standard enumeration string.
             * @author [email protected]
             */
            std::string enumerationString() const
```;
and in 
**libember\Headers\ember\glow\impl\GlowParameterBase.ipp** insert somewhere aroun line 312:
LIBEMBER_INLINE
std::string GlowParameterBase::enumerationString() const
{
    ber::Value const value = contents().get(GlowTags::ParameterContents::Enumeration());
    return util::ValueConverter::valueOf(value, std::string());
}
@KimonHoffmann
Copy link
Contributor

KimonHoffmann commented Jun 3, 2020

This looks like a sensible change.

To include it I would like to ask you for explicit permission to implement the change as described, but without any author information in the comment.

If you want author information to be preserved, please create a pull request (also without the author mentioned in the comment) that we can integrate.

@astedler
Copy link
Contributor Author

astedler commented Jun 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants