Skip to content

Commit

Permalink
Rename invocationCollection parameter to pendingInvocations
Browse files Browse the repository at this point in the history
References #8
  • Loading branch information
andreashuber-lawo committed Jan 8, 2016
1 parent 09fb6d2 commit f4f683b
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Lawo.EmberPlusSharp/Model/Element.cs
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ internal virtual bool WriteRequest(EmberWriter writer, IStreamedParameterCollect
return false;
}

internal abstract void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection);
internal abstract void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations);

internal virtual void SetComplete()
{
Expand Down
8 changes: 4 additions & 4 deletions Lawo.EmberPlusSharp/Model/FunctionBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal override RequestState ReadContents(EmberReader reader, ElementType actu
return RequestState.Complete;
}

internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection)
internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations)
{
if (this.HasChanges)
{
Expand All @@ -115,7 +115,7 @@ internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollec
writer.WriteValue(GlowQualifiedFunction.Path.OuterId, this.NumberPath);
writer.WriteStartApplicationDefinedType(
GlowQualifiedFunction.Children.OuterId, GlowElementCollection.InnerNumber);
this.WriteInvocations(writer, invocationCollection);
this.WriteInvocations(writer, pendingInvocations);
writer.WriteEndContainer();
writer.WriteEndContainer();
this.HasChanges = false;
Expand Down Expand Up @@ -195,15 +195,15 @@ private async Task<IResult> InvokeCoreAsync(object[] actualArguments)
this.arguments.Zip(actualArguments, (e, a) => CreateWriter(e, a)).ToArray());
}

private void WriteInvocations(EmberWriter writer, IInvocationCollection invocationCollection)
private void WriteInvocations(EmberWriter writer, IInvocationCollection pendingInvocations)
{
while (this.invocations.Count > 0)
{
writer.WriteStartApplicationDefinedType(GlowElementCollection.Element.OuterId, GlowCommand.InnerNumber);
writer.WriteValue(GlowCommand.Number.OuterId, 33);
writer.WriteStartApplicationDefinedType(GlowCommand.Invocation.OuterId, GlowInvocation.InnerNumber);
var invocation = this.invocations.Dequeue();
var invocationId = invocationCollection.Add(invocation.Key);
var invocationId = pendingInvocations.Add(invocation.Key);
writer.WriteValue(GlowInvocation.InvocationId.OuterId, invocationId);
writer.WriteStartSequence(GlowInvocation.Arguments.OuterId);

Expand Down
2 changes: 1 addition & 1 deletion Lawo.EmberPlusSharp/Model/Matrix.cs
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ internal override RequestState ReadContents(EmberReader reader, ElementType actu
return this.RequestState;
}

internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection)
internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations)
{
////if (this.HasChanges)
////{
Expand Down
4 changes: 2 additions & 2 deletions Lawo.EmberPlusSharp/Model/Node.cs
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,11 @@ internal sealed override RequestState ReadContents(EmberReader reader, ElementTy
return this.RequestState;
}

internal override void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection)
internal override void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations)
{
if (this.HasChanges)
{
this.WriteChangesCollection(writer, invocationCollection);
this.WriteChangesCollection(writer, pendingInvocations);
this.HasChanges = false;
}
}
Expand Down
4 changes: 2 additions & 2 deletions Lawo.EmberPlusSharp/Model/NodeBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ internal bool WriteCommandCollection(EmberWriter writer, IStreamedParameterColle
}
}

internal void WriteChangesCollection(EmberWriter writer, IInvocationCollection invocationCollection)
internal void WriteChangesCollection(EmberWriter writer, IInvocationCollection pendingInvocations)
{
foreach (var child in this.children.Values)
{
child.WriteChanges(writer, invocationCollection);
child.WriteChanges(writer, pendingInvocations);
}
}

Expand Down
2 changes: 1 addition & 1 deletion Lawo.EmberPlusSharp/Model/ParameterBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ internal override RequestState ReadContents(EmberReader reader, ElementType actu
return this.RequestState;
}

internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection)
internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations)
{
if (this.HasChanges)
{
Expand Down
4 changes: 2 additions & 2 deletions Lawo.EmberPlusSharp/Model/Root.cs
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,12 @@ internal sealed override bool WriteRequest(EmberWriter writer, IStreamedParamete
}

[SuppressMessage("Microsoft.Design", "CA1062:Validate arguments of public methods", Justification = "Method is not public, CA bug?")]
internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection)
internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations)
{
if (this.HasChanges)
{
writer.WriteStartApplicationDefinedType(GlowGlobal.Root.OuterId, GlowRootElementCollection.InnerNumber);
this.WriteChangesCollection(writer, invocationCollection);
this.WriteChangesCollection(writer, pendingInvocations);
writer.WriteEndContainer();
this.HasChanges = false;
}
Expand Down
2 changes: 1 addition & 1 deletion Lawo.EmberPlusSharp/Model/ShadowNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ internal sealed override RequestState ReadContents(EmberReader reader, ElementTy
throw new ModelException("Unexpected contents for intermediate node in basePath.");
}

internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection invocationCollection)
internal sealed override void WriteChanges(EmberWriter writer, IInvocationCollection pendingInvocations)
{
this.HasChanges = false;
}
Expand Down

0 comments on commit f4f683b

Please sign in to comment.