Skip to content

Commit

Permalink
Rename methods to better suit the previously renamed properties
Browse files Browse the repository at this point in the history
References #8
  • Loading branch information
andreashuber-lawo committed Dec 19, 2015
1 parent 91b112f commit 5703c8b
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
8 changes: 4 additions & 4 deletions Lawo.EmberPlusSharp/Model/Consumer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ private void OnHasChangesSet(object sender, EventArgs e)

private async Task QueryChildrenAsync()
{
var queryChildrenTask = this.QueryChildrenAsyncCore();
var queryChildrenTask = this.QueryChildrenCoreAsync();

if ((await Task.WhenAny(queryChildrenTask, Task.Delay(this.queryChildrenTimeout))) != queryChildrenTask)
{
Expand Down Expand Up @@ -300,9 +300,9 @@ private async void AutoSendLoop()
}
}

private async Task QueryChildrenAsyncCore()
private async Task QueryChildrenCoreAsync()
{
while (await this.SendChildrenQuery())
while (await this.SendRequestAsync())
{
await this.WaitForAndApplyChanges();
}
Expand Down Expand Up @@ -351,7 +351,7 @@ private async Task DelayAutoSend()
}
}

private async Task<bool> SendChildrenQuery()
private async Task<bool> SendRequestAsync()
{
var rootRequestState = this.root.UpdateRequestState(false);

Expand Down
4 changes: 2 additions & 2 deletions Lawo.EmberPlusSharp/Model/NodeBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal void ReadChild(EmberReader reader, ElementType actualType)
this.ReadChild(reader, actualType, reader.AssertAndReadContentsAsInt32());
}

internal void WriteChildrenQueryCollection(EmberWriter writer)
internal void WriteRequestCollection(EmberWriter writer)
{
if (this.children.Count == 0)
{
Expand Down Expand Up @@ -278,7 +278,7 @@ internal override void WriteRequest(EmberWriter writer)
GlowQualifiedNode.Children.OuterId, GlowElementCollection.InnerNumber);
}

this.WriteChildrenQueryCollection(writer);
this.WriteRequestCollection(writer);

if (isEmpty)
{
Expand Down
2 changes: 1 addition & 1 deletion Lawo.EmberPlusSharp/Model/Root.cs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ internal sealed override bool ReadChildrenCore(EmberReader reader)
internal sealed override void WriteRequest(EmberWriter writer)
{
writer.WriteStartApplicationDefinedType(GlowGlobal.Root.OuterId, GlowRootElementCollection.InnerNumber);
this.WriteChildrenQueryCollection(writer);
this.WriteRequestCollection(writer);
writer.WriteEndContainer();
}

Expand Down
10 changes: 5 additions & 5 deletions Lawo.EmberPlusSharp/S101/S101Client.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public byte KeepAliveRequestSlot
public Task SendOutOfFrameByteAsync(byte value)
{
this.AssertPreconditions();
return this.SendOutOfFrameByteAsyncCore(value);
return this.SendOutOfFrameByteCoreAsync(value);
}

/// <summary>Calls
Expand Down Expand Up @@ -231,7 +231,7 @@ public Task SendMessageAsync(S101Message message)
public Task SendMessageAsync(S101Message message, byte[] payload)
{
this.AssertPreconditions();
return this.SendMessageAsyncCore(message, payload);
return this.SendMessageCoreAsync(message, payload);
}

/// <summary>See <see cref="IDisposable.Dispose"/>.</summary>
Expand Down Expand Up @@ -369,7 +369,7 @@ private void DisposeCore(bool log)
}
}

private async Task SendMessageAsyncCore(S101Message message, byte[] payload)
private async Task SendMessageCoreAsync(S101Message message, byte[] payload)
{
await this.EnqueueLogOperation(() => this.logger.LogMessage(LogNames.Send, message, payload));

Expand All @@ -393,7 +393,7 @@ await this.sendQueue.Enqueue(
});
}

private async Task SendOutOfFrameByteAsyncCore(byte value)
private async Task SendOutOfFrameByteCoreAsync(byte value)
{
await this.EnqueueLogOperation(() => this.logger.LogData(LogNames.OutOfFrameByte, LogNames.Send, new[] { value }, 0, 1));
await this.sendQueue.Enqueue(() => this.writer.WriteOutOfFrameByteAsync(value, this.source.Token));
Expand All @@ -417,7 +417,7 @@ await Task.WhenAny(readTask, timeoutTask = Task.Delay(timeoutHalf), cancellation
switch (++timeoutCount)
{
case 1:
await this.SendMessageAsyncCore(
await this.SendMessageCoreAsync(
new S101Message(this.keepAliveRequestSlot, new KeepAliveRequest()), null);
break;
case 2:
Expand Down
4 changes: 2 additions & 2 deletions Lawo.EmberPlusSharp/S101/S101Writer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public Task DisposeAsync(CancellationToken cancellationToken)
/// <exception cref="ArgumentException"><paramref name="value"/> equals <c>0xFE</c>.</exception>
public Task WriteOutOfFrameByteAsync(byte value, CancellationToken cancellationToken)
{
return this.taskSingleton.Execute(() => this.WriteOutOfFrameByteAsyncCore(value, cancellationToken));
return this.taskSingleton.Execute(() => this.WriteOutOfFrameByteCoreAsync(value, cancellationToken));
}

/// <summary>Asynchronously writes <paramref name="message"/>.</summary>
Expand Down Expand Up @@ -145,7 +145,7 @@ private async Task<NonSeekableStream> WriteMessageCoreAsync(
return this.stream;
}

private async Task WriteOutOfFrameByteAsyncCore(byte value, CancellationToken cancellationToken)
private async Task WriteOutOfFrameByteCoreAsync(byte value, CancellationToken cancellationToken)
{
this.AssertNotDisposed();

Expand Down

0 comments on commit 5703c8b

Please sign in to comment.