Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOFTER Andpods and NextTransfer logos #2063

Merged
merged 32 commits into from
May 5, 2024

Conversation

AetherNo2332
Copy link
Contributor

Description

Add icons for the LOFTER AndPods Honkai:Star Rail cloud and NextTransfer
Linked WearOS icon for the China market version

Icons addition information

lofter.svg (com.lofter.android)
honkai_star_rail_cloud.svg (com.miHoYo.cloudgames.hkrpg)
and_pods.svg (cn.xiaolongonly.andpodsop)
next_transfer.svg (com.next.transfer)

Added

LOFTER (com.lofter.android)
Hongkai:Star rail · Cloud (com.miHoYo.cloudgames.hkrpg)
AndPods (cn.xiaolongonly.andpodsop)
Next Transfer (com.next.transfer)

Linked

WearOS (linked com.google.android.wearable.app.cn to @drawable/wear_os)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label May 2, 2024
Copy link
Collaborator

@x9136 x9136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Not bad for your first time. Something needs to be fixed.

Also, could you remove these updates from the PR?
Screenshot 2024-05-03 at 11 22 27

svgs/honkai_star_rail_cloud.svg Show resolved Hide resolved
svgs/lofter.svg Show resolved Hide resolved
svgs/next_transfer.svg Show resolved Hide resolved
@x9136 x9136 added the rework The team has requested changes in the issue or PR. label May 3, 2024
@AetherNo2332
Copy link
Contributor Author

The workflow will fail if the SVG-process folder is deleted. Is this okay?

@x9136
Copy link
Collaborator

x9136 commented May 3, 2024

The workflow will fail if the SVG-process folder is deleted. Is this okay?

It doesn't need to be updated or deleted. PRs for adding icons should only include appfilter.xml and icons.

@AetherNo2332 AetherNo2332 requested a review from x9136 May 4, 2024 04:56
svgs/and_pods.svg Show resolved Hide resolved
svgs/honkai_cloud.svg Outdated Show resolved Hide resolved
svgs/lofter.svg Show resolved Hide resolved
svgs/next_transfer.svg Show resolved Hide resolved
app/assets/appfilter.xml Show resolved Hide resolved
Corrected a file name and explanation

*updated
LOFTER, NextTransfer, Honkai, Star Rail Cloud

**Recovered
Andpods

***Corrected
drawable="honkai_cloud" name="云·星穹铁道 ~~ Honkai:Star rail · Cloud"

to

drawable="honkai_star_rail_cloud" name="云·星穹铁道 ~~ Honkai:Star rail · Cloud"
@AetherNo2332 AetherNo2332 requested a review from x9136 May 4, 2024 17:18
Copy link
Collaborator

@x9136 x9136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something else left (appfilter.xml, lofter.svg)

*
Honkai_Star_rail_Cloud > Honkai_Star_Rail_Cloud

**
Moved LOFTER's logo slightly to the right so that it looks closer to the visual center
@AetherNo2332 AetherNo2332 requested a review from x9136 May 5, 2024 15:49
@x9136 x9136 merged commit a97a19b into LawnchairLauncher:develop May 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants