-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new icons #2018
Added new icons #2018
Conversation
Alinma banking icon Saudi National Bank icon
added BingX app to `@drawable/bingx` in line 922 of appfilter.xml * BingX (`pro.bingbon.app/pro.bingintl.ui.activity.MainActivity}`) added Rabby Wallet app to `@drawable/rabby_wallet` in line 7263 of appfilter.xml * Rabby Wallet (`com.debank.rabbymobile/com.debank.rabbymobile.MainActivity`) added SMC app to `@drawable/smc` in line 8424 of appfilter.xml * SMC (`com.edgineers.smc/crc6475b17315fd000a00.SplashActivity`) added Dr. Alfagih app to `@drawable/dr._alfagih` in line 2502 of appfilter.xml * Dr. Alfagih (`com.dmfh.dmfh/com.dmfh.dmfh.ui.SplashScreen`) added Najm app to `@drawable/najm` in line 5769 of appfilter.xml * Najm (`com.najm.najm/com.najm.publicapp.SplashActivity`) added Phantom Wallet app to `@drawable/phantom` in line 6518 of appfilter.xml * Phantom Wallet (`app.phantom/app.phantom.MainActivity`) added SpotOnChain app to `@drawable/spotonchain` in line 8600 of appfilter.xml * SpotOnChain (`network.spotonchain/network.spotonchain.MainActivity`) added Dr. Alfagih app to `@drawable/dr_alfagih` in line 2502 of appfilter.xml * Dr. Alfagih (`com.dmfh.dmfh/com.dmfh.dmfh.ui.SplashScreen`) added Solflare Wallet app to `@drawable/solflare` in line 8479 of appfilter.xml * Solflare Wallet (`com.solflare.mobile/com.solflare.mobile.MainActivity`) added Haraj app to `@drawable/haraj` in line 3792 of appfilter.xml * Haraj (`com.haraj.app/com.haraj.app.main.MainActivity`) added Almanea app to `@drawable/almanea` in line 328 of appfilter.xml * Almanea (`com.almanea.android/com.almanea.android.MainActivity`) added Noon app to `@drawable/noon` in line 5946 of appfilter.xml * Noon (`com.noon.buyerapp/com.noon.buyerapp.MainActivity`)
added Themer app to `@drawable/themer` added Bouki app to `@drawable/bouki` added ANB Telemoney app to `@drawable/anb_telemoney` added Tamara app to `@drawable/tamara` added Tameeni app to `@drawable/tameeni` added DEXTools app to `@drawable/dextools`
Merging with parent branch
Hey! I looked at 5 random icons and none of them were as described in the Lawnicons guidelines. I have encountered incorrect stroke width, incorrect sizes and the use of fill. These are clearly not the only points that are made without taking into account the guidelines. For some reason, you decided to delete from appfilter.xml some added links. This is not worth doing. Also, you have added extra calendar links. Most likely you used the If you plan to redo the icons, then consider the guidelines not as recommendations, but as requirements. It is also worth making the description correct. Now, according to the description, you have added only 6 icons. |
Ok, I will revert all the commits I did and rework on the icons again, much appreciated. |
Description
Icons addition information
Added
Themer ('com.therxmv.telegramthemer/com.therxmv.telegramthemer.ui.MainActivity')
Bouki ('com.emcrey.riyadbank/com.emcrey.bouki.MainActivity')
ANB Telemoney ('telemoneyapp.anb.keystore/telemoneyapp.anb.keystore.MainActivity')
Tamara ('co.tamara.user/co.tamara.user.MainActivity')
Tameeni ('tameeni.com/tameeni.com.MainActivity')
DEXTools ('io.dextools.app/io.dextools.app.ui.splash.SplashActivity')
Linked
App Name (
telemoneyapp.anb.keystore/telemoneyapp.anb.keystore.launcher_2cfa478945145ffc9dff49d2d860c62dfd80892e28877b2ed1434c45f77637c8
→anb_telemoney.svg
)Contributor's checklist