-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality update #1 #1430
Quality update #1 #1430
Conversation
Damn, you've really added extra work for newbies in the process of adding icons. That sucks. |
are you complaining about the PR templates? |
That's right. You can see from the decision that it was made by people who don't care about the convenience of the contributors. Unfortunately, in such tasks good solutions appear only if convenience is a concern. |
while you're at it, i think it would be better if the Google Authenticator logo was single stroke instead of double stroke - that's debatable though, as the icon has some fancy overlap stuff going on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I'll make some updates to improve the icons in terms of quality and consistency with the guides. In fact, I round the corners, simplify the shapes, and change the fill to a stroke.