Quality update #1 #1430
Merged
Quality update #1 #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, you've really added extra work for newbies in the process of adding icons. That sucks. |
are you complaining about the PR templates? |
That's right. You can see from the decision that it was made by people who don't care about the convenience of the contributors. Unfortunately, in such tasks good solutions appear only if convenience is a concern. |
|
while you're at it, i think it would be better if the Google Authenticator logo was single stroke instead of double stroke - that's debatable though, as the icon has some fancy overlap stuff going on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll make some updates to improve the icons in terms of quality and consistency with the guides. In fact, I round the corners, simplify the shapes, and change the fill to a stroke.