Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CMakeLists.txt (for CLion and other IDEs that support it) #2

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Conversation

Fernthedev
Copy link
Contributor

This allows error linting and auto-complete for IDEs that use CMake such as CLion. However, it should be noted that you should continue using the build script as I have not validated whether CMake can or cannot compile using NDK.

@Lauriethefish
Copy link
Owner

Lauriethefish commented Feb 4, 2021

This is cool, but can you add libil2cpp to the include path and define ID?
Also, avoid using #{id} multiple times in the cmake file and instead use ${CMAKE_PROJECT_NAME}. (only use it in the project label)

I experience some issues with custom-types even then, but this doesn't happen to you, so we'll just say it's inconsistent and leave it at that. (it can't possibly be worse than vscode right?)

@Fernthedev
Copy link
Contributor Author

Custom-types works for me, you can open my TrickSaber project and see for yourself.

@Lauriethefish
Copy link
Owner

Yeah, that's fine. Probably just my PC being weird.

@Lauriethefish
Copy link
Owner

Lauriethefish commented Feb 4, 2021

One final change, there shouldn't be a need to directly add bs-hook or the modloader to the include path, even if it's optional - everyone just uses the fully qualified name for these.

@Fernthedev
Copy link
Contributor Author

One final change, there shouldn't be a need to manually add bs-hook or the modloader to the include path, even if it's optional - everyone just uses the fully qualified name for these.

Very well, I'll take those into account now

@Lauriethefish
Copy link
Owner

Looks good!

@Lauriethefish Lauriethefish merged commit 52a850f into Lauriethefish:main Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants