Skip to content

Commit

Permalink
[apache#2292] add web ui support for fileset catalog
Browse files Browse the repository at this point in the history
  • Loading branch information
LauraXia123 committed Apr 1, 2024
1 parent db36332 commit 41bd74a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ public void testClickSchemaLink() {
@Test
@Order(8)
public void testClickTableLink() {
catalogsPage.clickTableLink(
metalakeName, modifiedCatalogName, catalogType, schemaName, tableName);
catalogsPage.clickTableLink(metalakeName, modifiedCatalogName, catalogType, schemaName, tableName);
Assertions.assertTrue(catalogsPage.verifyShowTableTitle("Columns"));
Assertions.assertTrue(catalogsPage.verifyTableColumns());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,7 @@ public void clickDeleteCatalogBtn(String name) {

public void clickCatalogLink(String metalakeName, String catalogName, String catalogType) {
try {
String xpath =
"//a[@href='?metalake="
+ metalakeName
+ "&catalog="
+ catalogName
+ "&type="
+ catalogType
+ "']";
String xpath = "//a[@href='?metalake=" + metalakeName + "&catalog=" + catalogName + "&type=" + catalogType + "']";
WebElement link = tableGrid.findElement(By.xpath(xpath));
WebDriverWait wait = new WebDriverWait(driver, MAX_TIMEOUT);
wait.until(ExpectedConditions.elementToBeClickable(By.xpath(xpath)));
Expand All @@ -207,15 +200,14 @@ public void clickCatalogLink(String metalakeName, String catalogName, String cat
}
}

public void clickSchemaLink(
String metalakeName, String catalogName, String catalogType, String schemaName) {
public void clickSchemaLink(String metalakeName, String catalogName, String catalogType, String schemaName) {
try {
String xpath =
"//a[@href='?metalake="
+ metalakeName
+ "&catalog="
+ catalogName
+ "&type="
+"&type="
+ catalogType
+ "&schema="
+ schemaName
Expand All @@ -230,18 +222,14 @@ public void clickSchemaLink(
}

public void clickTableLink(
String metalakeName,
String catalogName,
String catalogType,
String schemaName,
String tableName) {
String metalakeName, String catalogName, String catalogType, String schemaName, String tableName) {
try {
String xpath =
"//a[@href='?metalake="
+ metalakeName
+ "&catalog="
+ catalogName
+ "&type="
+"&type="
+ catalogType
+ "&schema="
+ schemaName
Expand Down
1 change: 1 addition & 0 deletions web/src/app/metalakes/metalake/MetalakeView.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
getFilesetDetails,
setSelectedNodes
} from '@/lib/store/metalakes'
import { type } from 'os'

const MetalakeView = () => {
const dispatch = useAppDispatch()
Expand Down

0 comments on commit 41bd74a

Please sign in to comment.