RTL migration: file inputs #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
|
@chawes13 yes, this can be merged. I was just waiting to merge it after the fixes in the main PR were done. |
…-file-input-to-rtl
chawes13
added a commit
that referenced
this pull request
Sep 11, 2023
* Set up React Testing Library * Migrate Spinner * convert button tests from enzyme to rtl * remove unused imports * remove unused import * Update jest and set test environment to jsdom * Bump version * update checkbox.test.js tests * checkbox.test.js and checkbox-group.test.js complete * update button.test.js to use userevent * update color-input.test.js to rtl * remove unused imports * update date input * complete color-input and date-input * complete dropdown-checkbox-group * complete hidden input * complete icon-input * Fix date input issues * RTL migration: controls (#602) * Migrate paginator * Add comment * Remove unused import * Migrate tab-bar * RTL migration: modal (#601) * Initial commit * Clean up logs * Add tests more default close interactions * RTL migration: indicators (#600) * Migrate loading container * Migrate flash message * Migrate flash message container * Upgdate assertion * Partial cleanup; Address code review * Remove unecessary test * Remove moment dependency from DateInput test * Update ColorPicker component * Update DropdownCheckboxGroup * Update HiddenInput * Update IconInput * Update Spinner component * Bump minor version * Address comments * Fix trigger on keys util * Migrate color-picker * RTL migration: tables (#603) * RTL migration: labels (#607) * partial label folder tests * Clean up error label * Fix input error tests * Remove unused attribute * Fix input label tests * Migrate labeled-field tests * Fixes --------- Co-authored-by: Alex Jin <[email protected]> * RTL migration: inputs (#604) * Migrate input * Migrate textarea * Remove unused import * Migrate switch * Remove unused import * Migrate range-input * Migrate select * Migrate masked input * Migrate replace empty string value hoc * Migrate blur dirty * Migrate radio group input * Migrate cloudinary uploader * Be more explicit * Use toHaveAttribute * Do not reference id directly * RTL migration: file inputs (#590) * Migrate FileInput to RTL * Migrate CloudinaryFileInput to RTL --------- Co-authored-by: Conor <[email protected]> * Remove enzyme * Add act back to file input * Avoid race conditions with act * Update lock * Add test for read helper * Mock server...better * Address uncovered line in wrap-display-name * Remove unused default * Add coverage for modal * Increase dropdown select coverage * Increase color picker coverage * Increase color-input coverage * Increase to-hex coverage * Increase paginator coverage * Increase masked input coverage * Increase date input coverage * Increase radio group coverage * Improve cloudinary-uploader coverage * Improve coverage for getEnvVar * Improve sortable table coverage * Improve tab-bar coverage * Update trigger on keys * Add comment * Replace act with waitFor --------- Co-authored-by: Alex Jin <[email protected]> Co-authored-by: Conor Hawes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Author Checklist