Skip to content

Commit

Permalink
v7 Milestone (#481)
Browse files Browse the repository at this point in the history
* Add `hideLabel` prop (#227)

* add hideLabel prop, story

* update showLabel logic, add new story

* remove import

* Version bump: 3.7.0

* add input label test, fix range input test

* lint

* change range label prop name

* Add `Select` placeholder option by default (#256)

* add default placeholder

* Version bump: 3.12.0

* Lint rolling

* Mapping aria-disabled instead of disabled (#337)

* a11y group legends (#384)

* Default label component to a legend for checkbox group

* Default label component to a legend for radio group

* Remove custom style prop on button (#408)

* Remove custom style prop on button

* Remove disabled button test

* Cleanup

* Some formatting

* Priority -> variant

* Add migration guide

* Naming

* Consolidate examples

* Move deprecated migration guide to v6 milestone

* Fix merge conflict

* Take prop change name one level of abstraction further to accommodate changes in future

* Modify File Input to accept multiple files (#380)

* Initial refactor

* Replace remove button with customizable component that accepts handler

* POC for workaround with files failing to load (mostly a upstream cloudinary issue)

* Refactor to a controlled file input (#388)

* Initial proof-of-concept

* Clean up logic and add dev hints via prop types

* Always return an array

* Read files synchronously to avoid overwrites

* Modify markup to allow for focus styling

* Code review feedback

* Make cloudinary accept a file input and set the response appropriately

* Extract helpers into shared folder

* Override read files utility and clean up based on code review

* filter invalid props from getting passed to error label (incl. label = false)

* Return files on cloudinary read

* Code clean-up

* Update CloudinaryFileInput docs

* Update FileInput docs

* Bump size limit

* Bump to milestone

* Fix failing specs

* Remove duplicate import

* Fix merge conflicts

* Add specs for multiple file input

* Add coverage for inverse scenario

* Add missing tests for remove functionality

* Refactor FileInput using hooks

* Use hook import directly

* Safely mock global object in an isolated way

* Wrap component in act to ensure state updates have settled

* Add tests for error capture

* Cover ternary branching conditions

* Update migration guide

* Code review feedback

* Add new test

* Manually updating docs

* Refactor to always store values in an array

* Update migration guide based on input value change

* Update prop types

* Do not change initial value if not an array (it will flag form as dirty)

* Add thumbnail story

* Code review feedback

* Globally replace redux-forms

* Reference array instead of single file

* Add className to spinner component (#493)

* change id to classname on spinner component

* revert inadvertnet commit

* add className to spinner component

* passing tests and update version

* add notes on the migration guide file

* adding feedback changes

* fix migration guide

* update language in migration guide

* additional feedback comments

* update default prop

* add destructuring to props

* Small tweaks

* Add missing period

Co-authored-by: Conor Hawes <[email protected]>

* Made options & value as required for the TabBar component (#461)

* Made options & value as required for the TabBar component

* bump version

* update docs, storybook, tests. remove unneeded activeValue logic

* Small documentation tweaks

* Update docs and travis

* Address linting errors

* Address unrelated lint error

Co-authored-by: Conor <[email protected]>

* Issue #347 : Add remove button to default file input previews (#526)

* show clear button for single file upload

* formatting

* tests for clear file input btn

* make remove button for single file consistent with remove button for multiple files

* update docs

* run yarn docs manually

* Add small note to migration guide

Co-authored-by: Conor Hawes <[email protected]>

* 524 remove setter link (#528)

* Remove SetterLink

* Update docs

* Modal close refactor (#525)

* Prevent all methods of closure

* Update migration guide

* Make isOpen prop less confusing

* Manually update docs

* Pass redux flash message to dismiss fn (#522)

* Add ref forwarding to button (#542)

* Add button ref note to migration guide

* Fix tests and prop types (#553)

* Hotfix

* Be more specific

* Fix select test warnings

* Fix textarea test warnings

* Fix file input test warnings

* Dedupe yarn.lock file to help resolve issues

* allow cell to take custom properties like aria and data-cy per cell b… (#503)

* allow cell to take custom properties like aria and data-cy per cell by column

* versioning to 5.4.3

* add filterInvalidProps to DefaultCellComponent render

* add back space

* add sortable-table.test.js test for addition;

* remove custom class for valid dom prop

* add test for invalid DOM props on column

* Tweak formatting

* Remove unnecessary attributes

Co-authored-by: Conor Hawes <[email protected]>

* Do not overwrite default modal classes (#554)

* Add functionality

* Add specs

* Add story

* Update migration guide

* Tweak migration guide

* render caption in table if passed in as a prop (#540)

* render caption if passed in as a prop

* remove semicolons i missed

* migration guide

* Render caption as table's first descendant

* Add story

* Fix typo

* Rename file to match convention

* Fix more typos

* Add caption tests

Co-authored-by: Conor Hawes <[email protected]>

* Add GitHub issue templates (#555)

* Add issue templates

* Update FEATURE_REQUEST.md

* Add support for additional undocumented props (#556)

* Add support for additional undocumented props

* Update docs and support callback ref as a prop

* Actually update docs

* Add disabled class to outer field wrapper (#557)

* Add disabled class at top level

* Update spec

* Bug/react modal default (#559)

* Switch selector

* Apply aria-hidden on the browser

* Update documentation

* Fix prop documentation 😳

* Upgrade DateInput's react-datepicker dependency (#558)

* Add missing test case

* Upgrade to v2

* Upgrade to v3

* Update to v4

* Tweak formatting

* Update migration guide

* Update docs

* Use calendar ref

* Simplify implementation

* Generate docs after merge

* Write a better comment

* Extend radio checkbox prop types (#563)

* Do not use input prop types for a component that is not an input

* Isolate components to allow for checkbox and radio groups to receive bools

* Reuse type

* Fix tabbar prop type issue

* Remove unused import

* Update docs

* Upgrade to react-switch to v7 (#564)

* Update package independently (#565)

* Upgrade to react 17 (#569)

* Remove lp hoc (#562)

* Remove unused sortable imports

* Remove toggle usage from most components

* Update input-label

* Remove unused hoc

* Remove toggle and outside click hocs

* Port over most files from lp-hoc's cloudinary uploader

* Bring over cloudinary uploader and tweak tests

* Clean up util usage

* Use cloudinary hoc mock in file input test

* Officially remove lp-hoc from library

* Suppress unnecessary errors shown in modal

* Lint

* Add back export for cloudinary uploader util

* Update migration guide

* Fix heading formatting

* Update docs

* Always set a boolean value

* Add docs about breaking change

* Update docs after latest merge

* Be better at writing tests

* Coerce using Boolean constructor

* Allow specification of group's input props (#571)

* Fix watch infinite loop

* Avoid passing down class name and allow localized input prop overrides

* Update docs

* Add stories

* Add examples

Co-authored-by: Rachel Killackey <[email protected]>
Co-authored-by: David Pickart <[email protected]>
Co-authored-by: George Lee <[email protected]>
Co-authored-by: Angel Medina <[email protected]>
Co-authored-by: Nicole Dow <[email protected]>
Co-authored-by: Alexander Jin <[email protected]>
Co-authored-by: Ji H. Park <[email protected]>
  • Loading branch information
8 people authored Jul 6, 2022
1 parent 0adb6ca commit 3b6578b
Show file tree
Hide file tree
Showing 102 changed files with 5,332 additions and 4,395 deletions.
33 changes: 33 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_REPORT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
name: Bug Report
about: Report a bug with LPL's component library
labels: bug
---

<!--
Please fill out this template with all the relevant information so we can
understand what's going on and fix the issue. We encourage you to submit a PR
to fix the reported issue!
-->

## Environment

- `@launchpad/lp-components` version:
- `react` version:
- `node` version:

## Expected Behavior

## Current Behavior

## Steps to Reproduce
<!--
If possible, please create a repository that reproduces the issue with the
minimal amount of code possible.
-->

## Suggested Solution
<!--
It's ok if you don't have a suggested solution, but please let us know if you
have any ideas!
-->
19 changes: 19 additions & 0 deletions .github/ISSUE_TEMPLATE/FEATURE_REQUEST.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
name: Feature Request
about: Suggest a feature or a new component for LPL's component library
labels: enhancement
---

## Feature Description
<!-- Describe the issue(s) that the feature would address -->

## Suggested Solution
<!--
It's ok if you don't have a suggested solution, but please let us know if you
have any ideas!
-->

## Alternatives Considered / Existing Workarounds

## Additional Context
<!-- Add other information, screenshots, etc. about the request here -->
3 changes: 1 addition & 2 deletions .storybook/styles/components/_buttons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
&:hover{ cursor: pointer; }

&:focus{
border: none;
outline: none;
text-decoration: none;
}
}
Expand Down Expand Up @@ -79,6 +77,7 @@ button.button-chill:hover {
&:focus{ border: 1px solid $hover-bg; }

&.is-disabled{
background-color: $bg-1;
opacity: 0.4;
cursor: not-allowed;
}
Expand Down
23 changes: 22 additions & 1 deletion .storybook/styles/components/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,14 @@ select{
}
}

/*-----------------------
Radio
-----------------------*/
.RadioGroup {
label {
cursor: pointer;
}
}

/*-----------------------
Checkbox
Expand Down Expand Up @@ -197,6 +205,19 @@ input[type="checkbox"]{
}
}

/*-----------------------
Disabled
-----------------------*/

.disabled {
label {
cursor: default;
}

input[type="checkbox"], input[type="radio"] {
cursor: not-allowed;
}
}

/*-----------------------
Error
Expand Down Expand Up @@ -305,7 +326,7 @@ Uploader
}
}

.button-secondary-light>input{
input[type="file"]{
position:absolute;
top:0;
right:0;
Expand Down
2 changes: 1 addition & 1 deletion .storybook/styles/components/_spinner.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Spinner
-----------------------*/

#spinner {
.spinner {
@include rem(margin-top, 50px);
text-align: center;

Expand Down
6 changes: 6 additions & 0 deletions .storybook/styles/components/_table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,9 @@ th{
content:"";
}
}

.custom-caption {
font-weight: bold;
font-size: 0.8rem;
color: $blue-dark;
}
1 change: 1 addition & 0 deletions .storybook/styles/settings/variables/_colors.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//BLUE
$blue-light: #BEE4FF;
$blue-base: #6BC2FF;
$blue-dark: #006AB5;

//GREEN
$green-dark: #56C852;
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: node_js
cache: yarn
before_script:
- 'yarn lint'
- 'yarn lint --max-warnings=0'
- 'yarn size'
notifications:
email: false
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Documentation and usage info can be found in [docs.md](docs.md).
- [v4.0.0](migration-guides/v4.0.0.md)
- [v5.0.0](migration-guides/v5.0.0.md)
- [v6.0.0](migration-guides/v6.0.0.md)
- [v7.0.0](migration-guides/v7.0.0.md)

## Contribution

Expand Down
13 changes: 0 additions & 13 deletions __mocks__/@launchpadlab/lp-hoc.js

This file was deleted.

Loading

0 comments on commit 3b6578b

Please sign in to comment.