V3 #23
V3 #23
Conversation
chawes13
commented
Apr 3, 2023
•
chawes13
commented
- Resolves Add JSX a11y plugin #13
- Resolves Add rules for hooks #15
- Resolves fix for bug in rules about adding dependencies #19
- Resolves Update eslint-plugin-import to support eslint v8 #20
- Resolves Update eslint-plugin-react to support eslint v8 #21
- Resolves babel-eslint is deprecated #22
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "presets": ["@launchpadlab/babel-preset/react"] | |||
There was a problem hiding this comment.
This is needed in order to test the react plugins
| @@ -1,6 +1,7 @@ | |||
| language: node_js | |||
| node_js: | |||
| - '8' | |||
| - '18' | |||
| dist: focal | |||
There was a problem hiding this comment.
Without specifying the dist, Travis fails to locate GLIB_C (still, somehow 🙃)
| "main": "index.js", | ||
| "license": "MIT", | ||
| "author": "dpikt", | ||
| "engines": { | ||
| "node": ">= 10" |
There was a problem hiding this comment.
This aligns with @babel/eslint-parser's requirement
| "peerDependencies": { | ||
| "eslint": ">= 3.0.0" | ||
| "resolutions": { | ||
| "babel-plugin-lodash/@babel/types": "~7.20.0" |
There was a problem hiding this comment.
This plugin is kind of abandonware it seems. It relies on a deprecated method and pollutes the console with a bunch of messages about it. Since it's just a dev dependency, I really don't care about pinning it
| 'plugin:react-hooks/recommended', | ||
| 'plugin:jsx-a11y/recommended', |
There was a problem hiding this comment.
Out of curiosity, do you know if lp-components passes these a11y recommendations?
There was a problem hiding this comment.
I think it's very unlikely 😅 . But that's the point!
| @@ -1,13 +1,14 @@ | |||
| const execSync = require('child_process').execSync | |||
| const { ESLint } = require('eslint') | |||
