Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out nested fields without RelationDirective if _ is used. #114

Closed
LastDragon-ru opened this issue Jan 8, 2024 · 1 comment · Fixed by #127
Closed

Filter out nested fields without RelationDirective if _ is used. #114

LastDragon-ru opened this issue Jan 8, 2024 · 1 comment · Fixed by #127
Assignees
@LastDragon-ru
Labels
! Breaking change bug Something isn't working pkg: graphql scope: feat New feature or request
Milestone
6.x

Comments

@LastDragon-ru
Copy link
Owner

If the placeholder (_) is used we should filter out the fields without RelationDirective, because they probably are not relations and will throw an error if try to search/sort by them. Model is unknown while types generation so we cannot check it.

For explicit types there is no problem, because we are to expect they are written by hand specially for search/sort.
@LastDragon-ru LastDragon-ru added bug Something isn't working scope: feat New feature or request pkg: graphql ! Breaking change labels Jan 8, 2024
@LastDragon-ru LastDragon-ru added this to the Next milestone Jan 8, 2024
@LastDragon-ru LastDragon-ru mentioned this issue Jan 10, 2024
Merged
@LastDragon-ru LastDragon-ru mentioned this issue Jan 29, 2024
Merged
LastDragon-ru added a commit that referenced this issue Jan 29, 2024
@LastDragon-ru
feat(graphql)!: Input type auto-generation improvements (#127)
accd8bf 
Closes: #114
@LastDragon-ru
Copy link
Owner Author

LastDragon-ru commented Jan 29, 2024 •
edited
Loading

Input type auto-generation reworked, please see documentation.

@LastDragon-ru LastDragon-ru self-assigned this Jan 29, 2024
@LastDragon-ru LastDragon-ru mentioned this issue Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LastDragon-ru LastDragon-ru

Labels
! Breaking change bug Something isn't working pkg: graphql scope: feat New feature or request
Projects
None yet
Milestone
6.x
Development

Successfully merging a pull request may close this issue.

Input type auto-generation improvements LastDragon-ru/lara-asp
1 participant
@LastDragon-ru