Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh_CN] Improve Chinese translation #1959

Merged
merged 4 commits into from
Jan 19, 2022
Merged

[zh_CN] Improve Chinese translation #1959

merged 4 commits into from
Jan 19, 2022

Conversation

hmingv
Copy link
Contributor

@hmingv hmingv commented Jan 18, 2022

No description provided.

Copy link
Member

@andrey-helldar andrey-helldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You do not need to update the documentation files yourself. This is run automatically.
  2. You don't need to change the names of the keys. We know that there is an error in the current version, but this error is due to its presence in Laravel products and we cannot leave the string without translation.

@andrey-helldar
Copy link
Member

@hmingv, remove all changes from your PR except zh_CN locale.

@andrey-helldar andrey-helldar changed the title Improve Chinese translation [zh_CN] Improve Chinese translation Jan 18, 2022
Copy link
Member

@overtrue overtrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢您的贡献,我发现了一些多余空格和一些小的建议麻烦看看。

locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
@hmingv
Copy link
Contributor Author

hmingv commented Jan 18, 2022

@hmingv, remove all changes from your PR except zh_CN locale.

Okay. I deleted the commit.

@hmingv
Copy link
Contributor Author

hmingv commented Jan 18, 2022

@andrey-helldar I think this is a duplicate.

#1961

@andrey-helldar
Copy link
Member

@hmingv, let's finish this PR first, and then we'll see what the next one will bring.

locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
locales/zh_CN/zh_CN.json Outdated Show resolved Hide resolved
@andrey-helldar andrey-helldar merged commit 1939087 into Laravel-Lang:master Jan 19, 2022
@andrey-helldar
Copy link
Member

谢谢

@hmingv
Copy link
Contributor Author

hmingv commented Jan 20, 2022

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants