Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gu] New language #1849

Merged
merged 2 commits into from
Nov 3, 2021
Merged

[gu] New language #1849

merged 2 commits into from
Nov 3, 2021

Conversation

GeneralCheesecake
Copy link
Contributor

No description provided.

@caouecs
Copy link
Member

caouecs commented Sep 14, 2021

Thank you, but can you translate validation-inline.php and json file please ?

@andrey-helldar
Copy link
Member

@GeneralCheesecake, can you translate validation-inline.php and {locale}.json file please ?

@caouecs
Copy link
Member

caouecs commented Oct 21, 2021

@GeneralCheesecake ping

@caouecs
Copy link
Member

caouecs commented Nov 2, 2021

@Laravel-Lang/laravel-lang we publish, we close ?

@andrey-helldar
Copy link
Member

andrey-helldar commented Nov 2, 2021

@caouecs, I have no complaints about the current translation files. Plus they are clean.

I propose to accept these changes. And when @GeneralCheesecake returns, it will be able to translate other files as well.

Also, when accepting changes, our script will automatically create the missing files.

@luisprmat
Copy link
Member

I think that we must merge. Hopefully someone will translate the missing files later.

@caouecs caouecs merged commit 68b1f8d into Laravel-Lang:master Nov 3, 2021
@caouecs
Copy link
Member

caouecs commented Nov 3, 2021

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants