Use shorthand nullability typings for better readability #5733
Conversation
* add method to get ajax uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * use an abstract class * wip * Apply fixes from StyleCI [ci skip] [skip ci] * refactor uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * refactor rules * Apply fixes from StyleCI [ci skip] [skip ci] * move ajax to PRO, cleanup * Apply fixes from StyleCI [ci skip] [skip ci] * make attributes available for all subfields * fix tests * wip * Apply fixes from StyleCI [ci skip] [skip ci] * upload multiple and upload properly working 🙏 * fixes * Apply fixes from StyleCI [ci skip] [skip ci] * allow the configuration of valueWithoutPath call. * fix valid upload inside repeatables * Apply fixes from StyleCI [ci skip] [skip ci] * fix condition * cleanup * fix * Apply fixes from StyleCI [ci skip] [skip ci] * fix use case for enabling validation after entry is created * Apply fixes from StyleCI [ci skip] [skip ci] * dont save array keys * fix ajax validation * fix validation messages * Apply fixes from StyleCI [ci skip] [skip ci] * fixes ValidUpload * Apply fixes from StyleCI [ci skip] [skip ci] * dont json encode if casted in the model * Apply fixes from StyleCI [ci skip] [skip ci] * fix previous file identification in repeatable * Apply fixes from StyleCI [ci skip] [skip ci] * fix getting values * Apply fixes from StyleCI [ci skip] [skip ci] * add fake fields support * Apply fixes from StyleCI [ci skip] [skip ci] * wip add uploaders tests * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * add pro columns * fix test suite * fix tests * ffix tests * remove unused test views * add uploaders to test coverage * Apply fixes from StyleCI [ci skip] [skip ci] * add coverage folder to gitignore * make tests run faster by not reloading db when not necessary * add coverage to validation tests * add fake tests to uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * add more tests * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * add more upload assets * fixes * Apply fixes from StyleCI [ci skip] [skip ci] * fix single file * Apply fixes from StyleCI [ci skip] [skip ci] * add image column * fix tests * Apply fixes from StyleCI [ci skip] [skip ci] * remove hardcoded macro names * Apply fixes from StyleCI [ci skip] [skip ci] * remove double loop, fix single file uploader * Apply fixes from StyleCI [ci skip] [skip ci] * use a big increments and unsigned for primary key * handle pivot file deletion * Apply fixes from StyleCI [ci skip] [skip ci] * register events for relation models * Apply fixes from StyleCI [ci skip] [skip ci] * fix typo * Apply fixes from StyleCI [ci skip] [skip ci] * fix relationship uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * update temporary time key * save objects in the macro --------- Co-authored-by: StyleCI Bot <[email protected]>
* wip * clean up * add get uploadedFilesFromRequest to clean up uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * fix type cast * add summernote uploader * update summernote * add summernote * add more test assets --------- Co-authored-by: StyleCI Bot <[email protected]>
|
Hey @jnoordsij thanks for the contribution. 🙏 Would it be too much to ask to merge both PR's into a single one, since they address the same issue ? If you don't have time/will to do it, let me know and I can do that, I'd rather merge this as a single PR 👍 Cheers |
|
I'm all fine with adding the commit here to #5732. I've deliberately split them, as #5732 now only contains essential changes that are practically identical to the previous state, just solving the deprecations. This MR goes slightly further by actually introducing a single behavior change, and thus should arguably be handled with a little more care. Moreover, the changes are merely cosmetic and are not required to actually fix deprecation messages, like #5732. However, if you prefer handling it all together at once, just let me know and I'll cherry-pick this onto #5732. |
|
Thanks for the clarification. 🙏 I agree then, let's merge the other PR in v6, and mark this for v7, I agree that it's unlike that anyone is using Thanks @jnoordsij 🙏 |
jnoordsij
force-pushed
the
null-typing-improvements
branch
from
af9feb4 to
fff82d0
Compare
|
Sounds great! I've rebased this to resolve conflicts with the new target branch. |
WHY
BEFORE - What was wrong? What was happening before this PR?
When working on #5732, I encountered some other (nullable) types that could be simplified, to improve readability.
AFTER - What is happening after this PR?
Cleaner code.
HOW
How did you achieve that, in technical terms?
Use shorthand.
Is it a breaking change?
No (or not really); only the change in
RegisterUploadEvents::handleis a change in behavior, due to no longer allowingnull; however explicitnullpassing seems unlikely and unwanted here.How can we test the before & after?
??
If the PR has changes in multiple repos please provide the command to checkout all branches, eg.: