pass column subfields through guessing functions #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
fixes: https://github.com/Laravel-Backpack/PRO/issues/287
BEFORE - What was wrong? What was happening before this PR?
As reported, our "fluent column" definition was not passing the subfields through the guessing functions. That made the column work when defined as array, and break when defined in a fluent syntax.
AFTER - What is happening after this PR?
It passes through the same guessing functions as the array definition.
HOW
How did you achieve that, in technical terms?
Added the
subfields()method toCrudColumn, similar to how we have inCrudField.Is it a breaking change?
It shouldn't.