Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count the group by columns instead of select.* #5628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Aug 19, 2024

WHY

BEFORE - What was wrong? What was happening before this PR?

When having GROUP BY clauses we cannot add any other column to the count that's not on the GROUP BY clause, so our method of select something.* don't work as it would select columns that wont belong to the group by clause.

AFTER - What is happening after this PR?

It's working, it selects the "grouped columns" and don't any other columns to the select that are not in group by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant