-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle uploads inside relationships #5243
Conversation
[ci skip] [skip ci]
[ci skip] [skip ci]
…com/Laravel-Backpack/CRUD into handle-uploads-inside-relationships
[ci skip] [skip ci]
Hi @pxpm im testing this on demo using in demo "SkillCrudController" Set subfield
i add:
but im always getting:
and thats is because the real URL is:
because in the controller is set as:
I think we need to cover this scenario. Cheers. |
Hey @jorgetwgroup excelent catch! I totally missed it 🙏 I've submitted https://github.com/Laravel-Backpack/PRO/pull/200 to address the issue you reported, please confirm if it's ok to be merged 🙏 Apart from that, is this PR ready from your point of view ? If so I will clean up the code a bit, add some comments and ask @tabacitu for the final review 🙏 Thanks |
Hi @pxpm Everything is working now as expected. I test, image, dropzone upload and upload_multiple inside relationships they work normal, and with https://github.com/Laravel-Backpack/PRO/pull/200 is fixed the dropzone bug. For me look ready to merge. Cheers. |
[ci skip] [skip ci]
Uploaders didn't fully supported to be used inside relationships from the start.
I've now add that support, some relationships need some additional work from the developer that I documented here: Laravel-Backpack/docs#493
All other relation types shouldn't need any additional configuration from developer.
@jorgetwgroup I think this one needs an extra pair of eyes to make sure I didn't mess up. Can you help here with a review ?
I've used this branch https://github.com/Laravel-Backpack/demo/tree/test-relationship-uploaders that I created on demo to test.
We should test
upload
,image
,upload_multiple
anddropzone
inside those relationships.I haven't finish ALL tests, mainly I tested with
upload
field type, but I am going to test other field types this afternoon, and ping you here if I find something that caters your attention.Cheers