In show_fields, use getFirstFieldView() method
#4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of manually doing the same thing in the blade file
tabacitu
changed the title
tabacitu
changed the title
getFirstFieldView() method
|
This should also show a better error message. For example in Laravel-Backpack/PageManager#123 the new message should read "Cannot find 'normal' field view in any of the regular locations." which is a little more clear than the current "None of the views in the given array exist". |
tabacitu
deleted the
when-showing-fields-use-get-first-field-view-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of manually doing the same thing in the blade file.
WHY
BEFORE - What was wrong? What was happening before this PR?
In
show_fieldswe were doing the same thing as inCRUD::getFirstFieldView(), instead of calling that method.AFTER - What is happening after this PR?
We call
CRUD::getFirstFieldView()HOW
Is it a breaking change or non-breaking change?
Non-breaking.
How can we test the before & after?
Create in Monster & MenuItem should work before, should work after, and show all fields.