Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #105

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Staging #105

merged 4 commits into from
Dec 9, 2024

Conversation

avflay
Copy link

@avflay avflay commented Dec 2, 2024

No description provided.

romanidavies and others added 2 commits November 26, 2024 14:41
Updates to make

Reduce the size of the contents body (• review side navigation: size of font, spacing between contents is different to patterns used throughout the system - what do we want to do about this. Accessibility compliance.)

How accessible this website is section:

• review first bullet point content- add 'be' after 'may'

• remove '.' on last bullet point of first set of bullet points

• add comma after 'focus'

Feedback and contact info section:

• add fullstop at end of para (after email address)

• spacing before paragraph: 'What we're doing to improve accessibility'

• remove bold from failure sentences and put related sentence for description and failures in same paragraphs

• amend date to 31st March 2025 (see Adams message re: Convo with Josie Davey)
@avflay avflay requested a review from a team as a code owner December 2, 2024 15:24
@AndyPorter AndyPorter temporarily deployed to hmlr-design-system-pr-105 December 2, 2024 15:26 Inactive
romanidavies and others added 2 commits December 4, 2024 15:39
"when tabbing, focus may be lost"
…ment

Minor grammar amend to the Accessibility Statement
@AndyPorter AndyPorter temporarily deployed to hmlr-design-system-pr-105 December 4, 2024 15:46 Inactive
@avflay avflay requested a review from romanidavies December 9, 2024 10:22
@Erintregunna Erintregunna self-requested a review December 9, 2024 10:25
Copy link

@Erintregunna Erintregunna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved request. Query on grammar for the sentence: When browser text size is adjusted to 200% or 'very large' text 'overflows' which means that some words or sentences may be cut off and unreadable. This fails WCAG 2.2 Success criterion 1.4.10 (Reflow). Should we have a ',' between 'very large' and 'text'?

@avflay avflay merged commit 20cd3f8 into main Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants