Add title to the document.

LanDinh · Nov 15, 2023 · 0ba348f · 0ba348f
1 parent 0a1afb4
commit 0ba348f
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 17 deletions.
diff --git a/frontend/admin/app/root.tsx b/frontend/admin/app/root.tsx
@@ -1,6 +1,8 @@
 import { links, ErrorBoundary, App, handle } from './khaleesi/components/document'
-import { navigationProperties } from './khaleesi/navigation/navigationData'
+import { topNavigationData } from './khaleesi/navigation/commonNavigationData'
 
 
-export default App
-export { links, ErrorBoundary, navigationProperties, handle }
+const AdminApp = () => <App title="Admin Console" />
+export default AdminApp
+export { links, ErrorBoundary, handle }
+export const navigationProperties = topNavigationData[0]
diff --git a/frontend/khaleesi/app/khaleesi/components/document.tsx b/frontend/khaleesi/app/khaleesi/components/document.tsx
@@ -5,16 +5,18 @@ import { breadcrumb } from '../navigation/breadcrumb'
 import { Navigation } from '../navigation/navigation'
 import { Content } from './content'
 import { ErrorPage } from './error'
+// @ts-ignore: styles have no types
 import rootStyles from '../styles/index.css'
+// @ts-ignore: styles have no types
 import navigationBarStyles from '../styles/navigation.css'
-import { navigationProperties } from '../navigation/navigationData'
+import { topNavigationData } from '../navigation/commonNavigationData'
 
 
 export const handle = {
-  ...breadcrumb(navigationProperties),
+  ...breadcrumb(topNavigationData[0]),
 }
 
-function Document({ children }: PropsWithChildren<{}>): JSX.Element {
+function Document({ children, title }: PropsWithChildren<{ title: string }>): JSX.Element {
   return <html lang="en">
     <head>
       <meta charSet="utf-8" />
@@ -24,7 +26,7 @@ function Document({ children }: PropsWithChildren<{}>): JSX.Element {
     </head>
     <body>
       <div id="khaleesi-app">
-        <div id="khaleesi-title" className="khaleesi-bar">Title</div>
+        <div id="khaleesi-title" className="khaleesi-bar">{title}</div>
         <Navigation />
         <Content>
           {children}
@@ -44,14 +46,14 @@ export const links: LinksFunction = () => [
   { rel: 'stylesheet', href: navigationBarStyles },
 ]
 
-export function ErrorBoundary(): JSX.Element {
-  return <Document>
+export function ErrorBoundary({ title }: { title: string }): JSX.Element {
+  return <Document title={title}>
     <ErrorPage />
   </Document>
 }
 
-export function App(): JSX.Element {
-  return <Document>
+export function App({ title }: { title: string }): JSX.Element {
+  return <Document title={title}>
     <Outlet />
   </Document>
 }
diff --git a/frontend/khaleesi_frontend_tests/app/root.tsx b/frontend/khaleesi_frontend_tests/app/root.tsx
@@ -1,6 +1,8 @@
 import { links, ErrorBoundary, App, handle } from './khaleesi/components/document'
-import { navigationProperties } from './khaleesi/navigation/navigationData'
+import { topNavigationData } from './khaleesi/navigation/commonNavigationData'
 
 
-export default App
-export { links, ErrorBoundary, navigationProperties, handle }
+const TestApp = () => <App title="Test App" />
+export default TestApp
+export { links, ErrorBoundary, handle }
+export const navigationProperties = topNavigationData[0]
diff --git a/templates/frontend/frontend_template/app/root.tsx b/templates/frontend/frontend_template/app/root.tsx
@@ -1,6 +1,8 @@
 import { links, ErrorBoundary, App, handle } from './khaleesi/components/document'
-import { navigationProperties } from './khaleesi/navigation/navigationData'
+import { topNavigationData } from './khaleesi/navigation/commonNavigationData'
 
 
-export default App
-export { links, ErrorBoundary, navigationProperties, handle }
+const NewApp = () => <App title="Lorem Ipsum" />
+export default NewApp
+export { links, ErrorBoundary, handle }
+export const navigationProperties = topNavigationData[0]