(OpenBIOS) Change _bu_init() ROM offset from 0x55 to 0x70
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngineersBox
changed the title
_bu_init() ROM offset from 0x55 to 0x70_bu_init() ROM offset from 0x55 to 0x70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that emulators tend to prefer the
0x70offset for_bu_init()in BIOS implementations. Well at least PCSX's OpenBIOS does (hard to confirm in others, like ePSXe, no$psx, RetroArch/Liberto, etc since most are freeware/closed source).Given that PCSX-Redux runs pretty much any PS1 game to a T, then it would seem that builds with PsyQ implement
_bu_init()targetting ROM0xa0at offset0x70and not0x55, given that OpenBIOS only supports0x70currently. (I have an issue open with PCSX-Redux to change that and support both).This PR essentially just changes the target offset to match.