feat(YouTube/YT - GmsCore support): add patch option `Disable GmsServ…

…ice Broker` inotia00/ReVanced_Extended#2442 (comment)
Laitinlok · Oct 20, 2024 · 19a8677 · 19a8677
1 parent cae2f6c
commit 19a8677
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/main/kotlin/app/revanced/patches/shared/gms/BaseGmsCoreSupportPatch.kt b/src/main/kotlin/app/revanced/patches/shared/gms/BaseGmsCoreSupportPatch.kt
@@ -93,6 +93,7 @@ abstract class BaseGmsCoreSupportPatch(
 
         var gmsCoreVendor = "app.revanced"
         var checkGmsCore = true
+        var disableGmsServiceBroker = false
         var packageNameYouTube = "com.google.android.youtube"
         var packageNameYouTubeMusic = "com.google.android.apps.youtube.music"
 
@@ -131,6 +132,7 @@ abstract class BaseGmsCoreSupportPatch(
     override fun execute(context: BytecodeContext) {
         gmsCoreVendor = getStringPatchOption("GmsCoreVendorGroupId")
         checkGmsCore = getBooleanPatchOption("CheckGmsCore")
+        disableGmsServiceBroker = getBooleanPatchOption("DisableGmsServiceBroker")
         packageNameYouTube = getStringPatchOption("PackageNameYouTube")
         packageNameYouTubeMusic = getStringPatchOption("PackageNameYouTubeMusic")
 
@@ -152,12 +154,15 @@ abstract class BaseGmsCoreSupportPatch(
         }
 
         // Return these methods early to prevent the app from crashing.
-        listOf(
+        val returnEarly = mutableListOf(
             CastContextFetchFingerprint,
-            GmsServiceBrokerFingerprint,
             GooglePlayUtilityFingerprint,
             ServiceCheckFingerprint
-        ).returnEarly()
+        )
+        if (disableGmsServiceBroker) {
+            returnEarly += GmsServiceBrokerFingerprint
+        }
+        returnEarly.returnEarly()
 
         transformPrimeMethod()
 

diff --git a/src/main/kotlin/app/revanced/patches/shared/gms/BaseGmsCoreSupportResourcePatch.kt b/src/main/kotlin/app/revanced/patches/shared/gms/BaseGmsCoreSupportResourcePatch.kt
@@ -51,6 +51,19 @@ abstract class BaseGmsCoreSupportResourcePatch(
             """.trimIndentMultiline(),
         required = true,
     )
+
+    private val DisableGmsServiceBroker by booleanPatchOption(
+        key = "DisableGmsServiceBroker",
+        default = false,
+        title = "Disable GmsService Broker",
+        description = """
+            Disabling GmsServiceBroker will somewhat improve crashes caused by unimplemented GmsCore services.
+            
+            For YouTube, the 'Spoof streaming data' setting is required.
+            """.trimIndentMultiline(),
+        required = true,
+    )
+
     internal val PackageNameYouTube = stringPatchOption(
         key = "PackageNameYouTube",
         default = DEFAULT_PACKAGE_NAME_YOUTUBE,