Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file filter #1901

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix file filter #1901

merged 1 commit into from
Nov 12, 2024

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Nov 12, 2024

Description

The lbox change detection filter used incorrect base branch. Patched it by providing previous sdk release as an input

In the future we can improve by autodetecting the previous sdk verion

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky merged commit 91cbc90 into develop Nov 12, 2024
28 of 30 checks passed
@vbrodsky vbrodsky deleted the VB/fix-sdk-lbox-publish branch November 12, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants