-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLT-0] Improve Overall Dev-X By Using Rye #1492
Conversation
fe77c43
to
bb7878c
Compare
d7d1e8e
to
51c84a6
Compare
cdb9c57
to
2f1f859
Compare
8fe7612
to
8a1175e
Compare
3b5b05c
to
9b63b4b
Compare
6b2ba7f
to
737e992
Compare
I havent ever used rye before.. couple of qns.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! Left some questions
DA_GCP_LABELBOX_API_KEY: ${{ secrets[matrix.da-test-key] }} | ||
LABELBOX_TEST_ENVIRON: prod | ||
run: | | ||
rye add labelbox --path ./$(find ./dist/ -name *.tar.gz) --sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding it as a review comment so that it doesnt get missed out
I havent ever used rye before.. couple of qns.
Is it an alternative to poetry? why not poetry?
On their website they say "Rye is still a very experimental tool" ..so is it stable and used widely in the industry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://alpopkes.com/posts/python/packaging_tools/
^ look at the comparison, I personally don't want to deal with inconsistent environments (poetry doesn't solve the python-version problem, you'd have to use pyenv, something else)
https://astral.sh/blog/uv -> for corporate sponsorship
](https://star-history.com/#astral-sh/rye&python-poetry/poetry&Date) -> popularity, well I mean the creator did make Flask (if that is meaningful reputation wise).
https://rye-up.com/philosophy/
You can use poetry since, by definition, the pyproject.toml files are pep standard. Not against poetry, in fact, I've used / use it in other projects outside of LB.
example (open ai): https://github.com/openai/openai-python/blob/main/requirements.lock, codeinterpreter-api (https://github.com/shroominic/codeinterpreter-api/blob/main/requirements.lock)
To your point, there is some language (last year) indicating a more experimental attitude towards the work but the recent website updates are starting to eliminate this language.
827d1e6
to
d9a63dd
Compare
d9a63dd
to
68d47ae
Compare
8a64029
to
ebd7c29
Compare
ca4b4f9
to
9b710b4
Compare
Overall Goal: Improve Dev-X
Overall Strategy:
rye
as a baseline tool for all SDK Developmentpoetry
can be used also as standardpyproject.toml
setuptools
/setup.py
rye
labelbox
package followsrc/
folder conventionrye run unit
,rye run lint
,rye run integration
) is all that is needed. Nothing elselibs/
folder for future SDK modules outside oflabelbox
** See comment of Support subprojects in a poetry project python-poetry/poetry#2270, lack of monorepo support of poetry, well at least natively
TODO: