updated exception for get_data_row_by_global_keys #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislav-peharda
approved these changes
Mar 9, 2024
…ows-wrong-exception-on-not-found
manuaero
deleted the
1260-clientget_data_row_by_global_key-throws-wrong-exception-on-not-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this issue #1260 . I checked this method the res it gives is only {'status': 'FAILURE', 'results': [''], 'errors': [{'global_key': 't', 'error': 'Data Row not found'}]} . No matter if I have invalid characters or not meeting requirements from our docs: https://docs.labelbox.com/reference/data-row-global-keys#requirements. So I just switched it over to ResoruceNotFoundException I wrote a regex that would work to validate
^[^\s][a-zA-Z0-9!_.*'&$@=;\/:+ ]{1,200}[^\s]$that could be used to throw the MalformedQueryException SDK side. I don't have that regex added to the PR yet since i would have to import re and want an opinion on that