-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test updates for Firefox 128 #2043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
There are several problems that popped up when running tests on Firefox 128
UnhandledAlertException.getAlertText
no longer contains the alert text. ConfiguringsetUnhandledPromptBehaviour(UnexpectedAlertBehaviour.IGNORE)
will allow tests to get alert text withgetDriver().switchTo().alert().getText()
when encountering anUnhandledAlertException
. The default behavior was to dismiss those alerts, so I've also updated several base navigation/cleanup methods explicitly close the alerts (beginAtAcceptingAlerts
).CustomizeView.addColumn
was sometimes failing to add columns. There was no validation that the operation completed successfully, so tests failed log after the actual error occurred. In addition to fixing theaddColumn
functionality, I added some validation toCustomizeView.addItem
. That validation revealed that many tests were using incorrectly cased fieldKeys (the left panel has all-caps fieldKeys but the right panel does not).Firefox 128 replaces
%
s in downloaded file names with_
s. A couple of test required updates to handle that.Checkboxes on
StartImportPage
weren't getting reliably checked inAdvancedImportOptionsTest
. I moved that checkbox functionality out of the test intoStartImportPage.checkTargetFolders(String... folders)
to handle UI animation and ensuring the checkboxes are checked.Related Pull Requests
Changes
UnhandledAlertException
CustomizeView.addItem