Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updates for Firefox 128 #2043

Merged
merged 16 commits into from
Sep 11, 2024
Merged

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Sep 9, 2024

Rationale

There are several problems that popped up when running tests on Firefox 128

UnhandledAlertException.getAlertText no longer contains the alert text. Configuring setUnhandledPromptBehaviour(UnexpectedAlertBehaviour.IGNORE) will allow tests to get alert text with getDriver().switchTo().alert().getText() when encountering an UnhandledAlertException. The default behavior was to dismiss those alerts, so I've also updated several base navigation/cleanup methods explicitly close the alerts (beginAtAcceptingAlerts).

CustomizeView.addColumn was sometimes failing to add columns. There was no validation that the operation completed successfully, so tests failed log after the actual error occurred. In addition to fixing the addColumn functionality, I added some validation to CustomizeView.addItem. That validation revealed that many tests were using incorrectly cased fieldKeys (the left panel has all-caps fieldKeys but the right panel does not).

Firefox 128 replaces %s in downloaded file names with _s. A couple of test required updates to handle that.

Checkboxes on StartImportPage weren't getting reliably checked in AdvancedImportOptionsTest. I moved that checkbox functionality out of the test into StartImportPage.checkTargetFolders(String... folders) to handle UI animation and ensuring the checkboxes are checked.

Related Pull Requests

Changes

  • Handle new behavior of UnhandledAlertException
  • Add validation to CustomizeView.addItem
  • Add helper to parse boolean test properties
  • Handle Firefox download file name changes
  • Handle checkboxes on multi folder import

@labkey-tchad labkey-tchad merged commit 5e99d34 into release24.7-SNAPSHOT Sep 11, 2024
1 of 2 checks passed
@labkey-tchad labkey-tchad deleted the 24.7_fb_firefox128 branch September 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants