Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 50925: Refinements to peptide outlier heat map #943

Merged
merged 26 commits into from
Aug 23, 2024

Conversation

ankurjuneja
Copy link
Contributor

@ankurjuneja ankurjuneja commented Aug 11, 2024

Rationale

Following refinements are made in this PR-

  1. Show a loading indicator, both on the initial load and after toggling the date range.
  2. Show the number of replicates included in the date range instead of the total number in the folder.
  3. Get rid of the arrows on the side of the heat map legend.
  4. Vertically align the legend text with the center of the legend boxes.
  5. Reduce the number of boxes in the legend and add borders to make it consistent with the calendar heat map legend.
  6. Show the maximum number of outliers in the legend instead of "Most Outliers", making it consistent with the calendar views.
  7. Add the web part between the calendar and the QC summary web parts in targetedms-qcSummaryHistory.view.
  8. Re-title the "QC Summary" web part to "Replicate Summary" and "Outlier Heatmap Summary" to "Peptide/Molecule Summary"
  9. Sort any non-precursor based rows at the bottom.
  10. Show the unmodified peptide sequence. Don't let it wrap between the charge state and the MZ.

Related Pull Requests

Changes

@ankurjuneja ankurjuneja marked this pull request as ready for review August 15, 2024 01:53
@labkey-jeckels
Copy link
Contributor

Testing notes. Some are preexisting behaviors, some are new:

  1. Preexisting QC folders are missing their QC Summary web parts. We should be backwards compatible with the old name. See BaseWebPartFactory.addLegacyNames().
  2. Loading indicator looks good, though it's misleadingly cleared if you select a different date range twice in rapid succession. The indicator clears when the first response comes back, and then the content eventually gets swapped out with the second response. Ideally we'd keep the indicator spinning and perhaps even cancel the first request. Lower priority.
  3. When there are zero outliers for the time range, the table cells are blank instead of showing 0. The total columns show 0. If you have a single outlier anywhere in the table, the other cells get zeros. We should show zeros instead of blanks.
  4. I'm still seeing "QC Summary" as the web part title instead of "Replicate Summary" (see Issue 36585: QC plots in TargetedMS folders show values from all precursors of a peptide in a single plot #8 from the original list)

I imagine those will be small changes, but I'll hold my code review until you've had a chance to push fixes.

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previously posted comments for some testing feedback.

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small requests but no need for further review.

for (SampleFileInfo sampleFileInfo : sampleFileInfos)
{
DateFormat format = DateFormat.getDateInstance();
String acquiredTime = format.format(sampleFileInfo.getAcquiredTime());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we format this as a string and then immediately parse it back to a Date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing this to get the date only part. Thanks for the pointer, replaced it with DateUtil.getDateOnly

{
for (SampleFileInfo sampleFileInfo : sampleFileInfos)
{
DateFormat format = DateFormat.getDateInstance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use DateUtil.parseDate().

@ankurjuneja ankurjuneja merged commit 796a996 into develop Aug 23, 2024
4 of 5 checks passed
@ankurjuneja ankurjuneja deleted the fb_Issue50925 branch August 23, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants