Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop passing around email addresses #6021

Merged
merged 15 commits into from
Nov 7, 2024

Conversation

labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Nov 5, 2024

Rationale

https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=51520

Changes

  • Add UserId column to core.Logins and populate it from the core.Principals table. Make this the primary key.
  • Consolidate all core.Logins-handling methods from UserManager & SecurityManager into LoginManager. Migrate these methods and their callers to use UserId instead of email address.
  • Update actions to pass and use userId parameter
  • Update verification URLs to remove email parameter and not add userId. Verification is now a lookup based solely on the verification token.
  • Make Email column nullable and stop populating it. It'll get removed in 24.12.

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a handful of test failures.

api/src/org/labkey/api/security/LoginManager.java Outdated Show resolved Hide resolved
api/src/org/labkey/api/security/LoginManager.java Outdated Show resolved Hide resolved
api/src/org/labkey/api/security/LoginManager.java Outdated Show resolved Hide resolved
core/src/org/labkey/core/login/LoginController.java Outdated Show resolved Hide resolved
@labkey-adam
Copy link
Contributor Author

Looks like a handful of test failures.

Yep, working on those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants