Move ext-patches out of ExtJS library folder #5506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-klum
approved these changes
May 14, 2024
There was a problem hiding this comment.
CDS references one of these files:
https://github.com/LabKey/cds/blob/develop/src/org/labkey/cds/view/template/ConnectorTemplate.jsp#L104
Yup, thanks. LabKey/cds#651 |
labkey-jeckels
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This moves our patch files for ExtJS 3.x and 4.x out of their respective source directories and into a new
core/webapp/ext-patchesdirectory so they can be sourced from outside the file structure of these ExtJS libraries/packages. This in turn will make it so we don't need to manually publish new distribution artifacts when changes to these patch files are made.Related Pull Requests
Changes
ext-3.4.1/ext-patches.jstoextPatches/ext3-patches.jsext-4.2.1/ext-patches.jstoextPatches/ext4-patches.js