Update schema for donor metadata #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test data Refactor copy config constructors
22 tasks
labkey-bpatel
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec
Rationale
Previously, the donor information referenced by the mAb metadata table was 1:1. In the new schema, donors are no longer mAb-specific. They will now be tracking donors that do not necessarily have mAb values and will also have lineage sequences that do not relate to mAbs but do in fact relate to donors.
Changes
cds.donor_metadataandcds.donor_mab_sequencecds.antibody_sequencecds.mabMetadatato replace donor information with the FKdonor_metadata.donor_idfieldCDSImportCopyConfignow has more explicit control over whether theimport_intermediate tables are used during the import ETL process. Longer term it may make sense to stop using these intermediate tables to cut down on the number of hard tables as well as steps required when loading data. In many cases there is no transformation of the data from the intermediate to final destination tables and we may be able to just import directly into the destination tables.