Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDS learn group page refactor #645

Merged
merged 11 commits into from
Feb 27, 2024
Merged

CDS learn group page refactor #645

merged 11 commits into from
Feb 27, 2024

Conversation

labkey-klum
Copy link
Contributor

spec

Rationale

This PR pivots the source of the learn grid away from being sourced from queries from the study and cds tables and now sources them from the individual filters that are serialized as part of the saved group. This was the primary problem that was discovered where the groups that appeared in the home page listing differed from the groups that appeared in the learn grid. Additionally, information about the group in the learn grid could also be inaccurate where studies (or other column information) were associated with the group that was not saved in the initial filter.

Changes

  • Source the study, assay, species and product information directly from the group filters. These are serialized in a JSON format and new code was added to parse the levels and members.
  • Consolidate the group model and store:
    • There were two models and stores in the application, one for the group home page listing and the other for the group learn grid.
    • This was causing some problems when synchronizing the views after the group store was mutated.
    • Fields were unified and consolidated
    • The Connector.model.Group store was deleted. This was formerly the model and store for the home page listing. Now everything uses the newer Connector.app.model.Group model and associated store.

…, remove redundant group_type field in favor of the existing shared field.
….Group replaces both the home page listing and the learn group as the model and store.
Copy link
Contributor

@labkey-bpatel labkey-bpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. Now the newly saved group is reflected in the Learn grid, yay!

I did some manual testing, noticed a couple of things:

  1. For me, Learn groups is displaying 'No related species' and 'No related products' for species and products even though there are species and products associated with the group (counts that are displayed below the Active filters shows Species 1, Products 3, for ex.)
  2. Find subjects > by Assays > select an Assay > Save as group.. > In Learn Groups, I don't see Assays listed for that group, not sure where we landed on that, to show Assays or not to show Assays. Also, going to Group Summary, it displays the Assay under Studies, instead of studies associated with that assay.

@labkey-klum
Copy link
Contributor Author

  1. For me, Learn groups is displaying 'No related species' and 'No related products' for species and products even though there are species and products associated with the group (counts that are displayed below the Active filters shows Species 1, Products 3, for ex.)

I wouldn't expect species to get pulled into the grid unless it's explicitly on the filter.

  1. Find subjects > by Assays > select an Assay > Save as group.. > In Learn Groups, I don't see Assays listed for that group, not sure where we landed on that, to show Assays or not to show Assays. Also, going to Group Summary, it displays the Assay under Studies, instead of studies associated with that assay.

We should show the assay if you find subjects by assay type. Good catch on the Assay by study which can potentially have both study and assay information, I'll get that fixed.

@labkey-klum
Copy link
Contributor Author

@labkey-bpatel I pushed some changes to help with your second comment.

@labkey-bpatel
Copy link
Contributor

labkey-bpatel commented Feb 26, 2024

  1. For me, Learn groups is displaying 'No related species' and 'No related products' for species and products even though there are species and products associated with the group (counts that are displayed below the Active filters shows Species 1, Products 3, for ex.)

I wouldn't expect species to get pulled into the grid unless it's explicitly on the filter.

Got it, I thought so as well, but wanted to verify.

  1. Find subjects > by Assays > select an Assay > Save as group.. > In Learn Groups, I don't see Assays listed for that group, not sure where we landed on that, to show Assays or not to show Assays. Also, going to Group Summary, it displays the Assay under Studies, instead of studies associated with that assay.

We should show the assay if you find subjects by assay type. Good catch on the Assay by study which can potentially have both study and assay information, I'll get that fixed.

Verified, looks good.

@labkey-klum labkey-klum merged commit 4aefcbb into develop Feb 27, 2024
@labkey-klum labkey-klum deleted the fb_learn_group_store branch February 27, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants