-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDS learn group page refactor #645
Conversation
…, remove redundant group_type field in favor of the existing shared field.
…up studies in summary view
….Group replaces both the home page listing and the learn group as the model and store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. Now the newly saved group is reflected in the Learn grid, yay!
I did some manual testing, noticed a couple of things:
- For me, Learn groups is displaying 'No related species' and 'No related products' for species and products even though there are species and products associated with the group (counts that are displayed below the Active filters shows Species 1, Products 3, for ex.)
- Find subjects > by Assays > select an Assay > Save as group.. > In Learn Groups, I don't see Assays listed for that group, not sure where we landed on that, to show Assays or not to show Assays. Also, going to Group Summary, it displays the Assay under Studies, instead of studies associated with that assay.
I wouldn't expect species to get pulled into the grid unless it's explicitly on the filter.
We should show the assay if you find subjects by assay type. Good catch on the Assay by study which can potentially have both study and assay information, I'll get that fixed. |
@labkey-bpatel I pushed some changes to help with your second comment. |
|
spec
Rationale
This PR pivots the source of the learn grid away from being sourced from queries from the study and cds tables and now sources them from the individual filters that are serialized as part of the saved group. This was the primary problem that was discovered where the groups that appeared in the home page listing differed from the groups that appeared in the learn grid. Additionally, information about the group in the learn grid could also be inaccurate where studies (or other column information) were associated with the group that was not saved in the initial filter.
Changes
Connector.model.Group
store was deleted. This was formerly the model and store for the home page listing. Now everything uses the newerConnector.app.model.Group
model and associated store.