Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crawler test failure due to unexpected alert #125

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

The post-test crawler treats unexpected alert dialogs as failures. Stop presenting them to help reduce test noise.

Example failure:

https://teamcity.labkey.org/viewLog.html?buildId=2796872&tab=buildResultsDiv&buildTypeId=bt401

Changes

  • Convert alert to an Ext message dialog

@labkey-jeckels labkey-jeckels requested review from a team and labkey-tchad and removed request for a team December 19, 2023 19:13
@labkey-jeckels labkey-jeckels merged commit d864786 into develop Dec 19, 2023
4 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_sampleSheetCrawlerFix branch December 19, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants