Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to use DOM builder for error message #121

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Switch to use DOM builder for error message #121

merged 1 commit into from
Dec 8, 2023

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

We can do better at rendering the error message

Changes

  • Use DOM builder to construct the HTML

@labkey-jeckels labkey-jeckels merged commit aefa956 into release23.11-SNAPSHOT Dec 8, 2023
4 checks passed
@labkey-jeckels labkey-jeckels deleted the 23.11_fb_workbookId branch December 8, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XingY XingY XingY approved these changes

@labkey-chrisj labkey-chrisj Awaiting requested review from labkey-chrisj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-jeckels @XingY