Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable stricter type checks (for DbSchema) #119

Merged
merged 1 commit into from
Nov 1, 2023
Merged

re-enable stricter type checks (for DbSchema) #119

merged 1 commit into from
Nov 1, 2023

Conversation

labkey-matthewb
Copy link
Contributor

Rationale

timestamp -> datetime

Related Pull Requests

Changes

labkey-jeckels
labkey-jeckels approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to have <datatype> in these XML files at all? Especially for modules that only support one DB?

@labkey-matthewb
Copy link
Contributor Author

Is there a good reason to have <datatype> in these XML files at all? Especially for modules that only support one DB?

No not really.

@labkey-matthewb labkey-matthewb merged commit f7caa78 into develop Nov 1, 2023
2 checks passed
@labkey-matthewb labkey-matthewb deleted the fb_schemaxmltestcase_typecheck branch November 1, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-matthewb @labkey-jeckels