Adding pwebdashboard module. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed module (dashboard to pwebdashboard) - Declared dependency on TargetedMS module in build.gradle - Flagged module as Postgres only - Other code changes
labkey-jeckels
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made after review:
This module can only be added by site admins (PwebDashboardModule.getRequireSitePermission() returns true). It has been added in only one private folder on PanoramaWeb.
There are no db tables. The two tables added to the UserSchema both extend ContainerTable, and I confirmed that the container filter is applied correctly for the user's permissions. These tables are queried to render the usage charts in a Wiki page on PanoramaWeb. The charts and a couple of other user-defined queries should eventually be added to this module.