Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ensureTransaction instead of beginTransaction #189

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Use ensureTransaction instead of beginTransaction #189

merged 1 commit into from
Feb 28, 2024

Conversation

labkey-jeckels
Copy link

Rationale

beginTransaction() gets a new DB connection and starts a transaction, even if there's already a transaction underway. This can lead to self-deadlocks and other problems.

Related Pull Requests

Changes

  • Switch callers to use ensureTransaction()

bbimber
bbimber approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@bbimber bbimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @labkey-jeckels , I'll look for this in other code

@labkey-jeckels labkey-jeckels merged commit 382431d into develop Feb 28, 2024
4 of 6 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_ensureTransaction branch February 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbimber bbimber bbimber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-jeckels @bbimber