-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks very good. Very readable. I do know very little about machine learning, so some of my comments may be induced by that. Very nice that there are already some good tests.
There are a lot of comments on code style and readability. This is because the code was readable enough that the less readable parts stood out very clearly. Also there was a lot of code.
This review was not meant to come across as an insufferable know-it-all, so I do apologize for all the comments where that seems to be the case.
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 55.75%
=========================================
Files ? 5
Lines ? 226
Branches ? 0
=========================================
Hits ? 126
Misses ? 100
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. Just one comment on one of the changes.
No description provided.