Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init #1

Merged
merged 49 commits into from
Jan 30, 2019
Merged

Init #1

merged 49 commits into from
Jan 30, 2019

Conversation

sndrtj
Copy link
Contributor

@sndrtj sndrtj commented Jan 23, 2019

No description provided.

@sndrtj sndrtj requested a review from rhpvorderman January 23, 2019 16:55
Copy link
Member

@rhpvorderman rhpvorderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks very good. Very readable. I do know very little about machine learning, so some of my comments may be induced by that. Very nice that there are already some good tests.

There are a lot of comments on code style and readability. This is because the code was readable enough that the less readable parts stood out very clearly. Also there was a lot of code.

This review was not meant to come across as an insufferable know-it-all, so I do apologize for all the comments where that seems to be the case.

.travis.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rna_cd/__init__.py Show resolved Hide resolved
rna_cd/__init__.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e6888e6). Click here to learn what that means.
The diff coverage is 55.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   55.75%           
=========================================
  Files             ?        5           
  Lines             ?      226           
  Branches          ?        0           
=========================================
  Hits              ?      126           
  Misses            ?      100           
  Partials          ?        0
Impacted Files Coverage Δ
rna_cd/__init__.py 100% <100%> (ø)
rna_cd/models.py 23.33% <23.33%> (ø)
rna_cd/bam_process.py 39.65% <39.65%> (ø)
rna_cd/cli.py 75.71% <75.71%> (ø)
rna_cd/utils.py 94.59% <94.59%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6888e6...fa02ca1. Read the comment docs.

Copy link
Member

@rhpvorderman rhpvorderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Just one comment on one of the changes.

rna_cd/bam_process.py Show resolved Hide resolved
@sndrtj sndrtj merged commit 3395637 into master Jan 30, 2019
@sndrtj sndrtj deleted the init branch February 14, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants