Remove lambda funcs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+753
to
+756
| def N_func(x, y): | ||
| return a[0] | ||
| self.N_interp = N_func | ||
| self.N_fit = N_func |
There was a problem hiding this comment.
A few things here:
- I don't know if this will pickle, but we'll find out. It's probably fine, I'm just not sure how different this actually will be to using a
lambda. - The function takes two parameters, ignores both of them, and just returns the first line of the file regardless? That seems odd.
There was a problem hiding this comment.
It is odd but the default is that it depends on two parameters. So to remain generic I define this dummy function with two parameters that always return the same value for N or theta
mfisherlevine
added a commit
to lsst/Spectractor
that referenced
this pull request
Mar 29, 2022
DM-34226: Update Spectractor fork with PR LSSTDESC#91 from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove lambda functions to make pickles with the outputs