Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench #46

Merged
merged 19 commits into from
Mar 24, 2020
Merged

Bench #46

merged 19 commits into from
Mar 24, 2020

Conversation

jeremyneveu
Copy link
Collaborator

MInor bugs and API improvements to generalise spectractor to different telescopes and instruments

@jeremyneveu
better parameters for HG-AR lamp at 200mm
570253a
@jeremyneveu
add comments in header; add xyz positions for LPNHE bench
7f105e6
@jeremyneveu
remove obsolete LSHIFT keyword from header
26d7820
@jeremyneveu
possibility to load a config file when instanciating an Image or Spec…
8c6d21c 
…trum object to load some default parameters for the experiement, as DISTANCE2CCD
@jeremyneveu
remove extract_info_CTIO_header function
ada4f57
@jeremyneveu
add GRATING keyword in Spectrum and Image header
f9e6e76
@jeremyneveu
Add deg threshold option into config and parameters
1bc8df9
@jeremyneveu
new settings
7ef71bc
@jeremyneveu
better loading of grating label and D2CDD; warning if spectrogram or …
aac3a61 
…table.csv files are absent
@jeremyneveu
add ROT_ANGLE_MIN and ROT_ANGLE_MAX
c29fc2f
@jeremyneveu
update headers with more keywords
c33a324
@jeremyneveu
repair doctests from_lambda_to_colormap
416f89b
@jeremyneveu
new keywords in header
61875a9
@jeremyneveu
better path handling
f61b2b6
@jeremyneveu
add try/except to load image or spectrum
2c406ac
@coveralls
Copy link

coveralls commented Mar 23, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 778

  • 61 of 65 (93.85%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 84.476%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/images.py 31 32 96.88%
spectractor/extractor/spectrum.py 20 23 86.96%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/spectrum.py 1 92.86%
Totals Coverage Status
Change from base Build 766: 0.03%
Covered Lines: 5360
Relevant Lines: 6345
💛 - Coveralls

@jeremyneveu jeremyneveu merged commit 0a2084a into master Mar 24, 2020
@jeremyneveu jeremyneveu mentioned this pull request Apr 16, 2020
Closed
4 tasks
jeremyneveu added a commit that referenced this pull request Jun 24, 2020
@jeremyneveu
Merge pull request #46 from LSSTDESC/bench
c8f1291 
Bench
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyneveu @coveralls