Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fitchromaticpsf1d #38

Merged
merged 23 commits into from
Sep 26, 2019
Merged

Fitchromaticpsf1d #38

merged 23 commits into from
Sep 26, 2019

Conversation

jeremyneveu
Copy link
Collaborator

replace minuit fit for ChromaticPSF1D class with gradient descent: faster, more robust, no randomness.

@coveralls
Copy link

coveralls commented Sep 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 529

  • 219 of 562 (38.97%) changed or added relevant lines in 9 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+6.005%) to 82.914%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/simulation/image_simulation.py 6 8 75.0%
spectractor/extractor/spectrum.py 0 3 0.0%
spectractor/fit/fitter.py 54 57 94.74%
spectractor/extractor/psf.py 101 107 94.39%
spectractor/fit/fit_spectrum.py 14 114 12.28%
spectractor/fit/fit_spectrogram.py 41 270 15.19%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/psf.py 6 87.71%
Totals Coverage Status
Change from base Build 497: 6.005%
Covered Lines: 4751
Relevant Lines: 5730
💛 - Coveralls

@jeremyneveu
Copy link
Collaborator Author

I think this PR solve the issue of Issue #32 concerning the randomness of the chromatic PSF fit. @mfisherlevine can you check that please ?

@jeremyneveu jeremyneveu merged commit a00d276 into master Sep 26, 2019
@jeremyneveu jeremyneveu deleted the fitchromaticpsf1d branch April 15, 2020 21:39
jeremyneveu added a commit that referenced this pull request Jun 25, 2020
@jeremyneveu
Merge pull request #38 from LSSTDESC/fitchromaticpsf1d
30fb2c6 
Fitchromaticpsf1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisherlevine mfisherlevine Awaiting requested review from mfisherlevine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremyneveu @coveralls