Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gaia spectra and SED errors + small debugs #160

Merged
merged 14 commits into from
Nov 15, 2024
Merged

Add Gaia spectra and SED errors + small debugs #160

merged 14 commits into from
Nov 15, 2024

Conversation

jeremyneveu
Copy link
Collaborator

@jeremyneveu jeremyneveu commented Nov 15, 2024

  • Use gaiaspec library from @corentinravoux
  • add SED uncertainty in forward modelling
  • debugging (in particular "noprior" method and "least_squares" method)

@jeremyneveu jeremyneveu changed the title Debug Add Gaia spectra and SED errors + small debugs Nov 15, 2024
@jeremyneveu
Copy link
Collaborator Author

@corentinravoux are you happy with those changes for now?

@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11854660698

Details

  • 82 of 164 (50.0%) changed or added relevant lines in 6 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.4%) to 88.841%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/fit/fit_spectrogram.py 5 14 35.71%
spectractor/fit/fit_spectrum.py 4 13 30.77%
spectractor/extractor/targets.py 59 123 47.97%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/targets.py 1 67.1%
spectractor/extractor/background.py 1 96.88%
spectractor/extractor/spectrum.py 6 92.05%
spectractor/extractor/images.py 12 89.79%
Totals Coverage Status
Change from base Build 11841890043: -0.4%
Covered Lines: 7635
Relevant Lines: 8594

💛 - Coveralls

@corentinravoux
Copy link
Collaborator

I created a first version of gaiaspec (https://github.com/corentinravoux/gaiaspec/releases/tag/v1.0.0) which is the one that I am using with Spectractor right now

Copy link
Collaborator

@corentinravoux corentinravoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current gaiaspec version worked on usdf with the commit "add sed error". From the changes I am seeing on the "small debugs" commit, I do not think it can cause a failure, at least on the gaiaspec side

@jeremyneveu jeremyneveu merged commit 19c4abb into master Nov 15, 2024
1 of 2 checks passed
@jeremyneveu jeremyneveu deleted the debug branch November 15, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants