-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gaia spectra and SED errors + small debugs #160
Conversation
jeremyneveu
commented
Nov 15, 2024
•
edited by corentinravoux
Loading
edited by corentinravoux
- Use gaiaspec library from @corentinravoux
- add SED uncertainty in forward modelling
- debugging (in particular "noprior" method and "least_squares" method)
@corentinravoux are you happy with those changes for now? |
Pull Request Test Coverage Report for Build 11854660698Details
💛 - Coveralls |
I created a first version of gaiaspec (https://github.com/corentinravoux/gaiaspec/releases/tag/v1.0.0) which is the one that I am using with Spectractor right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current gaiaspec version worked on usdf with the commit "add sed error". From the changes I am seeing on the "small debugs" commit, I do not think it can cause a failure, at least on the gaiaspec side