-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat and star_field #149
Merged
Merged
Flat and star_field #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10563651422Details
💛 - Coveralls |
…tes pure spectrogram and spectrum models, no additional features
Adr and debug outlier sigma clipping
…g all psf parameters, not only gamma
…tted on ratio data where BG40 data are rescaled by a factor 1.09
…der PSF shape parameter is fitted for higher diffraction orders; reshape spectrum.spectrogram_fit spectrum.spectrogram_residuals as 2D arrays; mask cosmics on fit residuals after each ffm iterations
… but fixed y_c; fixed A1 but free A2; debug masking; only zeroth-order polynomial parameter for high diffraction order PSF shape parameters
… 1.09), fixed A1s, free angstrom exponent with 20230802 data
… 1.09), fixed A1s, free angstrom exponent with 20230802 data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to include flat and star field simulations in the full forward model.
In addition to these primary objectives, code was improved in the following way:
General
Extraction:
Fit spectrogram
Auxtel