Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat and star_field #149

Merged
merged 138 commits into from
Nov 14, 2024
Merged

Flat and star_field #149

merged 138 commits into from
Nov 14, 2024

Conversation

jeremyneveu
Copy link
Collaborator

@jeremyneveu jeremyneveu commented Jan 23, 2024

The goal of this PR is to include flat and star field simulations in the full forward model.

  • flat
  • star field
  • mask exposure
  • add correct order ratios for auxtel

In addition to these primary objectives, code was improved in the following way:

General

  • masking of the pixels not maximally covered by the layers of the PSF cube
  • higher diffraction order footprints enlarge to fit first order footprint
  • use mask to remove cosmics
  • fix A3 to zero
  • use canonical polynomial parametrisation by default
  • more robust way to set weight of outliers to zero

Extraction:

  • restrict PSF Moffat boundaries,
  • fit angle and shift_y,
  • no wavelength evolution of PSF for higher dffraction orders
  • adjust A1 to help finding the spectrogram trace before FFM

Fit spectrogram

  • adjust A1, shift_y and angle before complete fit
  • no wavelength evolution of PSF for higher dffraction orders

Auxtel

  • large uncertainties for throughput below 380nm and above 1000nm
  • extrapolation of the ratio 2/1 and 3/2 using a hologram transmission model
  • beginning of a full chain test

@coveralls
Copy link

coveralls commented Jan 23, 2024

Pull Request Test Coverage Report for Build 10563651422

Details

  • 640 of 776 (82.47%) changed or added relevant lines in 17 files are covered.
  • 27 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.8%) to 89.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/config.py 1 2 50.0%
spectractor/tools.py 29 30 96.67%
spectractor/fit/fit_spectrum.py 9 12 75.0%
spectractor/extractor/images.py 48 52 92.31%
spectractor/fit/fit_spectrogram.py 94 99 94.95%
spectractor/extractor/extractor.py 125 131 95.42%
spectractor/fit/fitter.py 12 18 66.67%
spectractor/extractor/chromaticpsf.py 63 73 86.3%
spectractor/extractor/psf.py 60 75 80.0%
spectractor/simulation/image_simulation.py 116 135 85.93%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/spectrum.py 3 92.06%
spectractor/extractor/extractor.py 4 88.75%
spectractor/simulation/image_simulation.py 5 83.75%
tests/test_fullchain.py 15 62.67%
Totals Coverage Status
Change from base Build 10563263662: -0.8%
Covered Lines: 7602
Relevant Lines: 8528

💛 - Coveralls

Jérémy Neveu and others added 29 commits August 8, 2024 03:34
Adr and debug outlier sigma clipping
…tted on ratio data where BG40 data are rescaled by a factor 1.09
…der PSF shape parameter is fitted for higher diffraction orders; reshape spectrum.spectrogram_fit spectrum.spectrogram_residuals as 2D arrays; mask cosmics on fit residuals after each ffm iterations
… but fixed y_c; fixed A1 but free A2; debug masking; only zeroth-order polynomial parameter for high diffraction order PSF shape parameters
… 1.09), fixed A1s, free angstrom exponent with 20230802 data
… 1.09), fixed A1s, free angstrom exponent with 20230802 data
@jeremyneveu jeremyneveu merged commit 1ab853e into master Nov 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants