Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.0.2 #140

Merged
merged 6 commits into from
Oct 31, 2023
Merged

V3.0.2 #140

merged 6 commits into from
Oct 31, 2023

Conversation

jeremyneveu
Copy link
Collaborator

@jeremyneveu jeremyneveu commented Oct 15, 2023

  • add timeout errors in case of bad data quality or bad initialisation of the fit
  • replace mirror diameter parameters by effective surface parameter
  • increase PWV upper bound

@coveralls
Copy link

coveralls commented Oct 15, 2023

Pull Request Test Coverage Report for Build 6705096320

  • 15 of 18 (83.33%) changed or added relevant lines in 7 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 91.426%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/spectrum.py 2 3 66.67%
spectractor/fit/fitter.py 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/spectrum.py 7 91.43%
Totals Coverage Status
Change from base Build 6485351757: -0.05%
Covered Lines: 6963
Relevant Lines: 7616

💛 - Coveralls

Jérémy Neveu added 4 commits October 31, 2023 06:55
…CY, OBS_TELESCOPE_TRANSMISSION, add OBS_SURFACE in parameters for effective collection surface of telescope
@jeremyneveu jeremyneveu self-assigned this Oct 31, 2023
@jeremyneveu jeremyneveu merged commit 625b659 into master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants